Skip to content

Commit

Permalink
restore comment changes
Browse files Browse the repository at this point in the history
  • Loading branch information
JoeWang1127 committed Nov 23, 2023
1 parent b71c6bc commit 1173150
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,13 @@
*
* <p>URL Fetch is only available on Google App Engine (not on any other Java environment), and is
* the underlying HTTP transport used for App Engine. Their implementation of {@link
* HttpURLConnection} is simply an abstraction layer on top of URL Fetch. By implementing transport
* that directly uses URL Fetch, we can optimize the behavior slightly, and can potentially take
* advantage of features in URL Fetch that are not available in {@link HttpURLConnection}.
* Furthermore, there is currently a serious bug in how HTTP headers are processed in the App Engine
* implementation of {@link HttpURLConnection}, which we are able to avoid using this
* implementation. Therefore, this is the recommended transport to use on App Engine.
* HttpURLConnection} is simply an abstraction layer on top of URL Fetch. By implementing a
* transport that directly uses URL Fetch, we can optimize the behavior slightly, and can
* potentially take advantage of features in URL Fetch that are not available in {@link
* HttpURLConnection}. Furthermore, there is currently a serious bug in how HTTP headers are
* processed in the App Engine implementation of {@link HttpURLConnection}, which we are able to
* avoid using this implementation. Therefore, this is the recommended transport to use on App
* Engine.
*
* @since 1.10
* @author Yaniv Inbar
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1103,7 +1103,7 @@ public HttpResponse execute() throws IOException {
span.end(OpenCensusUtils.getEndSpanOptions(response == null ? null : response.getStatusCode()));

if (response == null) {
// Retries did not help resolve the executed exception, re-throw it.
// Retries did not help resolve the execute exception, re-throw it.
throw executeException;
}
// response interceptor
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,16 +41,16 @@
* <p>Users should consider modifying the keep alive property on {@link NetHttpTransport} to control
* whether the socket should be returned to a pool of connected sockets. More information is
* available <a
* href="http://docs.oracle.com/javase/7/docs/technotes/guides/net/http-keepalive.html">here</a>.
* href='http://docs.oracle.com/javase/7/docs/technotes/guides/net/http-keepalive.html'>here</a>.
*
* <p>We honor the default global caching behavior. To change the default behavior use {@link
* HttpURLConnection#setDefaultUseCaches(boolean)}.
*
* <p>Implementation is thread-safe. For maximum efficiency, applications should use a single
* globally-shared instance of the HTTP transport.
*
* @author Yaniv Inbar
* @since 1.0
* @author Yaniv Inbar
*/
public final class NetHttpTransport extends HttpTransport {
private static Proxy defaultProxy() {
Expand Down

0 comments on commit 1173150

Please sign in to comment.