Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: demo of base changes for google-http-client-apache-v3 #1959

Closed
wants to merge 2 commits into from

Conversation

diegomarquezp
Copy link
Contributor

@diegomarquezp diegomarquezp commented Jun 26, 2024

More PRs will come based on this branch. This is only for display purposes.

The project has the following dependency tree:

[INFO] --- dependency:3.6.1:tree (default-cli) @ google-http-client-apache-v3 ---
[INFO] com.google.http-client:google-http-client-apache-v3:jar:1.44.3-SNAPSHOT
[INFO] +- com.google.http-client:google-http-client:jar:1.44.3-SNAPSHOT:compile
[INFO] |  +- com.google.code.findbugs:jsr305:jar:3.0.2:compile
[INFO] |  +- com.google.errorprone:error_prone_annotations:jar:2.23.0:compile
[INFO] |  +- com.google.guava:guava:jar:30.1.1-android:compile
[INFO] |  |  +- com.google.guava:failureaccess:jar:1.0.1:compile
[INFO] |  |  +- com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava:compile
[INFO] |  |  \- org.checkerframework:checker-compat-qual:jar:2.5.5:compile
[INFO] |  +- com.google.j2objc:j2objc-annotations:jar:2.8:compile
[INFO] |  +- io.grpc:grpc-context:jar:1.60.1:compile
[INFO] |  |  \- io.grpc:grpc-api:jar:1.60.1:runtime
[INFO] |  +- io.opencensus:opencensus-api:jar:0.31.1:compile
[INFO] |  \- io.opencensus:opencensus-contrib-http-util:jar:0.31.1:compile
[INFO] +- junit:junit:jar:4.13.2:test
[INFO] |  \- org.hamcrest:hamcrest-core:jar:1.3:test
[INFO] +- org.apache.httpcomponents:httpclient:jar:4.5.14:compile
[INFO] |  +- commons-logging:commons-logging:jar:1.2:compile
[INFO] |  \- commons-codec:commons-codec:jar:1.11:compile
[INFO] \- org.apache.httpcomponents.core5:httpcore5-h2:jar:5.2.4:compile
[INFO]    \- org.apache.httpcomponents.core5:httpcore5:jar:5.2.4:compile

We need to directly exclude Core 4.x from google-http-java-client and org.apache.httpcomponents:httpclient. That leaves the project with only Core 5.x. This produces some compilation errors (link) that cannot be addressed due to the fact that Core 4.x is a transitive dependency of Client 4.x.

@diegomarquezp diegomarquezp added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 26, 2024
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Jun 26, 2024
@diegomarquezp diegomarquezp changed the title chore: demo of base change of google-http-client-apache-v3 chore: demo of base changes for google-http-client-apache-v3 Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant