Swallow exception from close call when there is an underlying IOException #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the code more consistent with the example on Closeables#closeQuietly javadoc
|
@chajath any updates on this? We are seeing some Dataflow customers facing issues where they cannot debug the underlying exception thrown? Do you know when will this be released? |
|
I haven't heard anything back yet. I will follow up with the team if I don't hear back soon. |
|
As a Dataflow customer we would really love to see some progress on this (: |
|
There's also #334 that I've opened that should fix the build. |
|
Thanks, looking forward to the fix. I'm the Dataflow user. This fix will help us debug what is happening in the my Pipeline --- at the moment, there is no info on what is making it fail. |
clundin25
pushed a commit
to clundin25/google-http-java-client
that referenced
this pull request
Aug 11, 2022
* updated versions.txt [ci skip] * updated appengine/pom.xml [ci skip] * updated bom/pom.xml [ci skip] * updated credentials/pom.xml [ci skip] * updated oauth2_http/pom.xml [ci skip] * updated pom.xml [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been numerous reports of users of the client library seeing IO exceptions bearing the message "insufficient data written" (googleapis/google-api-java-client#781 googleapis/google-api-java-client#782 googleapis/google-cloud-java#1018)
I believe these error messages are misleading, and are secondary effect of attempting to close the stream when the underlying IO operation was actually failing (see underlying close implementation)
Therefore I propose we handle the case when there has been an underlying IO exception error, we still attempt to close the stream but let the original IO exception propagate nonetheless.