Skip to content

Commit

Permalink
fix: unnecessary boxed primitives in AutoValue classes
Browse files Browse the repository at this point in the history
Fixes

```
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/TableResult.java:42: error: [AutoValueUnnecessaryBoxing] property method com.google.cloud.bigquery.TableResult.getTotalRows() is primitive but parameter of setter method is not
    public abstract TableResult.Builder setTotalRows(Long totalRows);
                                        ^
```

See google/auto@328a25c
  • Loading branch information
cushon committed Aug 29, 2024
1 parent 421c825 commit c29f669
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
7 changes: 6 additions & 1 deletion google-cloud-bigquery/clirr-ignored-differences.xml
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,9 @@
<className>com/google/cloud/bigquery/StandardTableDefinition*</className>
<method>*BigLakeConfiguration(*)</method>
</difference>
</differences>
<difference>
<differenceType>7005</differenceType>
<className>com/google/cloud/bigquery/TableResult*</className>
<method>*setTotalRows(*)</method>
</difference>
</differences>
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public abstract static class Builder {
* Sets the total number of rows in the complete result set, which can be more than the number
* of rows in the first page of results returned by {@link #getValues()}.
*/
public abstract TableResult.Builder setTotalRows(Long totalRows);
public abstract TableResult.Builder setTotalRows(long totalRows);

public abstract TableResult.Builder setJobId(JobId jobId);

Expand Down

0 comments on commit c29f669

Please sign in to comment.