-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for user defined TVFs #1278
feat: add support for user defined TVFs #1278
Conversation
update license headers update license headers update license headers
e9fc698
to
6c7f05b
Compare
Codecov Report
@@ Coverage Diff @@
## master #1278 +/- ##
============================================
- Coverage 80.19% 80.12% -0.08%
- Complexity 1271 1277 +6
============================================
Files 79 80 +1
Lines 6639 6665 +26
Branches 767 771 +4
============================================
+ Hits 5324 5340 +16
- Misses 917 923 +6
- Partials 398 402 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but seems like you should augment google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/RoutineTest.java to exercise the optional returnTableType so you retain coverage.
added additional test in RoutineTest |
🤖 I have created a release \*beep\* \*boop\* --- ## [1.129.0](https://www.github.com/googleapis/java-bigquery/compare/v1.128.3...v1.129.0) (2021-05-11) ### Features * add support for user defined TVFs ([#1278](https://www.github.com/googleapis/java-bigquery/issues/1278)) ([89958e9](https://www.github.com/googleapis/java-bigquery/commit/89958e9b5e4330b31878aa31b90569d2fd0310f2)) ### Dependencies * update dependency com.google.apis:google-api-services-bigquery to v2-rev20210422-1.31.0 ([#1275](https://www.github.com/googleapis/java-bigquery/issues/1275)) ([acc88c5](https://www.github.com/googleapis/java-bigquery/commit/acc88c5de445d166055825bf51d56a031e642675)) * update dependency com.google.apis:google-api-services-bigquery to v2-rev20210430-1.31.0 ([#1285](https://www.github.com/googleapis/java-bigquery/issues/1285)) ([e74ae1c](https://www.github.com/googleapis/java-bigquery/commit/e74ae1c180c8ce27c9c8985c1935a894889b6375)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v1.1.0 ([#1290](https://www.github.com/googleapis/java-bigquery/issues/1290)) ([e60f2cd](https://www.github.com/googleapis/java-bigquery/commit/e60f2cd823b1551e43154f87a5157acca51b346c)) * update jmh.version to v1.30 ([#1281](https://www.github.com/googleapis/java-bigquery/issues/1281)) ([3704a6c](https://www.github.com/googleapis/java-bigquery/commit/3704a6cc46b84ce3b5ba01466ba39333f1b16886)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
java-format requires JRE v11+ to run linter. It still check older code, just jre has to be 11+: google/google-java-format#529 Updating ci.yaml template since it is applicable for all the libraries. Source-Link: googleapis/synthtool@42a3786 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:14ecf64ec36f67c7bf04e3dc0f68eafcc01df3955121c38862b695e2ae7515d8
Allow BigQuery client library users to define table-valued functions (TVFs) that return table data.