Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add query dryRun logic to get the schema when null schema is returned from the backend #2106

Merged
merged 6 commits into from
Jul 20, 2022
Merged

fix: Add query dryRun logic to get the schema when null schema is returned from the backend #2106

merged 6 commits into from
Jul 20, 2022

Conversation

prash-mi
Copy link
Contributor

@prash-mi prash-mi commented Jun 8, 2022 •
edited
Loading

Added dryRun Logic in query RPC when the backend returns a null schema for the Fast query path
Added unit test case and minor refactor

Fixes #2103 #2114 and #2113 ☕️

@prash-mi prash-mi requested a review from a team June 8, 2022 06:16
@prash-mi prash-mi requested a review from gnanda June 8, 2022 06:16
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/java-bigquery API. labels Jun 8, 2022
@prash-mi prash-mi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 8, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 8, 2022
@prash-mi
Copy link
Contributor Author

blocked on b/235591056

This was referenced Jun 10, 2022
Closed
Closed
@prash-mi prash-mi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 14, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 14, 2022
@prash-mi prash-mi added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 14, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 14, 2022
@prash-mi prash-mi requested a review from a team as a code owner June 14, 2022 08:32
@prash-mi
Copy link
Contributor Author

@gnanda The failing integration tests are now passing, can you please have a look and let me know

@prash-mi prash-mi marked this pull request as draft June 23, 2022 05:04
@prash-mi prash-mi changed the title fix: Flaky NPE in testIterateAndOrder fix: Add query dryRun logic to get the schema when null schema is returned from the backend Jul 19, 2022
@prash-mi prash-mi marked this pull request as ready for review July 19, 2022 06:22
@prash-mi prash-mi added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 19, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 19, 2022
shollyman
shollyman approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per discussion, add instrumentation to disambiguate non-complete and missing schema cases.

@prash-mi
Copy link
Contributor Author

@shollyman Thanks Seth. I have added the additional logs.

@prash-mi prash-mi added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 20, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 20, 2022
@prash-mi prash-mi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 20, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 20, 2022
@prash-mi prash-mi merged commit c98d22b into googleapis:main Jul 20, 2022
@release-please release-please bot mentioned this pull request Jul 20, 2022
Merged
This was referenced Jul 22, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

@gnanda gnanda Awaiting requested review from gnanda

Assignees

@shollyman shollyman

Labels
api: bigquery Issues related to the googleapis/java-bigquery API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bigquery.it.ITNightlyBigQueryTest: testIterateAndOrder failed
4 participants
@prash-mi @shollyman @stephaniewang526 @yoshi-kokoro