Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable Lossless Timestamps in BQ java client lib #3589

Merged
merged 4 commits into from
Dec 2, 2024
Merged

Conversation

whuffman36
Copy link
Contributor

With discovery revision 20240124 or later, the BQ discovery document now properly exposes the API functionality to use lossless timestamps (DataFormatOptions.UseInt64Timestamp). This can be supplied as part of the jobs.query request, as well as passed as arguments to tabledata.list / jobs.getQueryResults.

This change enables the toggling of lossless timestamps in the java client library for BQ. The former format is still usable and is used by default. Users must opt in to use this feature.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/java-bigquery API. labels Nov 21, 2024
@whuffman36 whuffman36 marked this pull request as ready for review November 21, 2024 01:23
@whuffman36 whuffman36 requested a review from a team as a code owner November 21, 2024 01:23
@whuffman36 whuffman36 requested review from suzmue, shollyman and PhongChuong and removed request for suzmue November 21, 2024 01:23
Copy link
Contributor

@PhongChuong PhongChuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Just a few minor comments/change requests.

@whuffman36 whuffman36 merged commit c0b874a into main Dec 2, 2024
17 checks passed
@whuffman36 whuffman36 deleted the timestamps branch December 2, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants