feat: Add schema comparision to the main request loop for multiplexing to correctly update schema #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prerequisite for multiplexing client
new stream name as a switch of destinationt
also fixed a tiny bug inside fake bigquery write impl for getting thre response from offset
possible the proto schema does not contain this field
possible the proto schema does not contain this field
product-auto-label
bot
added
size: m
GaoleMeng
changed the title
yirutang
reviewed
Nov 3, 2022
...oud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/ConnectionWorker.java
Show resolved
Hide resolved
...oud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1/StreamWriterTest.java
Outdated
Show resolved
Hide resolved
…te for the same stream name can be notified
yirutang
approved these changes
Nov 3, 2022
GaoleMeng
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Nov 8, 2022
🤖 I have created a release *beep* *boop* --- ## [2.25.0](https://togithub.com/googleapis/java-bigquerystorage/compare/v2.24.2...v2.25.0) (2022-11-08) ### Features * Add schema comparision to the main request loop for multiplexing to correctly update schema ([#1865](https://togithub.com/googleapis/java-bigquerystorage/issues/1865)) ([cb18d28](https://togithub.com/googleapis/java-bigquerystorage/commit/cb18d288f78773af60b9fddc583f46a571cbc3f4)) ### Documentation * Remove stale header guidance for AppendRows ([#1866](https://togithub.com/googleapis/java-bigquerystorage/issues/1866)) ([1de23be](https://togithub.com/googleapis/java-bigquerystorage/commit/1de23be7fe84747a4e7ca5b511458a5b378a1170)) ### Dependencies * Update dependency com.google.cloud:google-cloud-bigquery to v2.18.2 ([#1862](https://togithub.com/googleapis/java-bigquerystorage/issues/1862)) ([ca2cafe](https://togithub.com/googleapis/java-bigquerystorage/commit/ca2cafe095eca8b610ec8ca1acf95cf7a561af61)) * Update dependency com.google.cloud:google-cloud-bigquery to v2.19.0 ([#1871](https://togithub.com/googleapis/java-bigquerystorage/issues/1871)) ([4aa967a](https://togithub.com/googleapis/java-bigquerystorage/commit/4aa967a0a30db0037a04b6b47646ae79dfffaead)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.6 ([#1870](https://togithub.com/googleapis/java-bigquerystorage/issues/1870)) ([17b2a80](https://togithub.com/googleapis/java-bigquerystorage/commit/17b2a8036cf5706cb753f7116b1fa424a661ba39)) * Update dependency kr.motd.maven:os-maven-plugin to v1.7.1 ([#1868](https://togithub.com/googleapis/java-bigquerystorage/issues/1868)) ([08b8468](https://togithub.com/googleapis/java-bigquerystorage/commit/08b8468dc31fe654f5f7a345377b14f51f19eeea)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.