Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add configuration in json steam writer to configure the timeout in request waiting queue #2362

Merged
merged 2 commits into from
Jan 10, 2024
Merged

feat: add configuration in json steam writer to configure the timeout in request waiting queue #2362

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
932ee57
make the request timeout configurable in connection worker
GaoleMeng Jan 5, 2024
3ef60ec
feat: add api to set the maximum wait queue wait time
GaoleMeng Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/JsonStreamWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import com.google.api.gax.rpc.TransportChannelProvider;
import com.google.protobuf.Descriptors;
import java.io.IOException;
import java.time.Duration;
import java.util.Map;
import org.json.JSONArray;

Expand Down Expand Up @@ -193,6 +194,16 @@ public static Builder newBuilder(String streamOrTableName, BigQueryWriteClient c
SchemaAwareStreamWriter.newBuilder(streamOrTableName, client, JsonToProtoMessage.INSTANCE));
}

/**
* Sets the maximum time a request is allowed to be waiting in request waiting queue. Under very
* low chance, it's possible for append request to be waiting indefintely for request callback
* when Google networking SDK does not detect the networking breakage. The default timeout is 15
* minutes. We are investigating the root cause for callback not triggered by networking SDK.
*/
public static void setMaxRequestCallbackWaitTime(Duration waitTime) {
ConnectionWorker.MAXIMUM_REQUEST_CALLBACK_WAIT_TIME = waitTime;
}

@Override
public void close() {
this.schemaAwareStreamWriter.close();
Expand Down
Loading