Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: v1alpha client generation #2615

Merged
merged 16 commits into from
Aug 27, 2024
Merged

feat: v1alpha client generation #2615

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
b9f9e60
chore: update generation config to include v1alpha
PhongChuong Aug 21, 2024
e562b01
fix inlining REPO_FULL_NAME in if statement
diegomarquezp Aug 21, 2024
0226a0e
Update hermetic_library_generation.yaml
diegomarquezp Aug 21, 2024
5c7c910
trigger generation
diegomarquezp Aug 21, 2024
a0c13a9
chore: generate libraries at Wed Aug 21 20:23:01 UTC 2024
cloud-java-bot Aug 21, 2024
bbe31c8
Merge branch 'main' into b361379510
PhongChuong Aug 22, 2024
203fcd1
update pom file to have the correct snapshot version for v1alpha
PhongChuong Aug 22, 2024
22d2221
update v1alpha pom to the correct snapshot image
PhongChuong Aug 22, 2024
7fc2d9c
update grpc v1alpha pom to the correct snapshot image
PhongChuong Aug 22, 2024
5d37325
Update generation_config.yaml
blakeli0 Aug 26, 2024
e71da12
Merge branch 'main' into b361379510
blakeli0 Aug 26, 2024
17e9343
chore: generate libraries at Mon Aug 26 17:59:57 UTC 2024
cloud-java-bot Aug 26, 2024
e4aaaf8
remove extra dep. proto-google-iam-v1
PhongChuong Aug 26, 2024
2610e91
remove extra dep. proto-google-common-protos
PhongChuong Aug 26, 2024
d813e24
readd the dep. proto-google-common-protos
PhongChuong Aug 26, 2024
771d37e
remove unused the dep. proto-google-common-protos from grpc-...
PhongChuong Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/hermetic_library_generation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ env:
jobs:
library_generation:
# skip pull requests coming from a forked repository
if: github.env.REPO_FULL_NAME == github.repository
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blakeli0 inlining the org/repo as an env var seems to break this if statement

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably because REPO_FULL_NAME is not referenced as a variable like $REPO_FULL_NAME?

if: ${{ github.event.pull_request.head.repo.full_name == github.repository }}
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 2 additions & 0 deletions generation_config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,7 @@ libraries:
recommended_package: com.google.cloud.bigquery.storage.v1
GAPICs:
- proto_path: google/cloud/bigquery/storage/v1
- proto_path: google/cloud/bigquery/storage/v1alpha
- proto_path: google/cloud/bigquery/storage/v1beta1
- proto_path: google/cloud/bigquery/storage/v1beta2

Loading