Skip to content

Commit

Permalink
deps: remove explicit log4j2 deps on beam artifacts as they are no lo…
Browse files Browse the repository at this point in the history
…nger brought in transitively (#3394)

* deps: remove explicit log4j2 deps on beam artifacts as they are no longer brought in transitively

* Release-As: v2.0.0-beta5
  • Loading branch information
kolea2 authored Dec 15, 2021
1 parent 3e3a560 commit 2dafd59
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 33 deletions.
17 changes: 0 additions & 17 deletions bigtable-dataflow-parent/bigtable-beam-import/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -246,12 +246,6 @@ limitations under the License.
<version>1.21</version>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-api</artifactId>
<version>${log4j2.version}</version>
</dependency>


<!-- Test Group -->
<dependency>
Expand Down Expand Up @@ -434,17 +428,6 @@ limitations under the License.
</configuration>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<configuration>
<ignoredUnusedDeclaredDependencies>
<!-- log4j-api dependency is added to enforce log4j versions with CVE fixes -->
<ignoredUnusedDeclaredDependency>org.apache.logging.log4j:log4j-api</ignoredUnusedDeclaredDependency>
</ignoredUnusedDeclaredDependencies>
</configuration>
</plugin>

<plugin>
<groupId>com.google.cloud.bigtable.test</groupId>
<artifactId>bigtable-build-helper</artifactId>
Expand Down
16 changes: 0 additions & 16 deletions bigtable-dataflow-parent/bigtable-hbase-beam/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -141,12 +141,6 @@ limitations under the License.
<version>${beam-slf4j.version}</version>
</dependency>

<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-api</artifactId>
<version>${log4j2.version}</version>
</dependency>

<!-- Test Group -->
<dependency>
<groupId>org.mockito</groupId>
Expand Down Expand Up @@ -325,16 +319,6 @@ limitations under the License.
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<configuration>
<ignoredUnusedDeclaredDependencies>
<!-- log4j-api dependency is added to enforce log4j versions with CVE fixes -->
<ignoredUnusedDeclaredDependency>org.apache.logging.log4j:log4j-api</ignoredUnusedDeclaredDependency>
</ignoredUnusedDeclaredDependencies>
</configuration>
</plugin>
</plugins>
</build>
</project>

0 comments on commit 2dafd59

Please sign in to comment.