Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch-up handover review with missing features and review comments #3347

Merged
merged 86 commits into from
May 11, 2022
Merged

Catch-up handover review with missing features and review comments #3347

merged 86 commits into from
May 11, 2022

Commits on May 11, 2022

  1. chore: revert review comments

    @dopiera @prawilny
    dopiera authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    6edf7c0 View commit details
    Browse the repository at this point in the history

  2. feat: add MirroringOperationException exception markers (#125)

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    e750ea9 View commit details
    Browse the repository at this point in the history

  3. feat: concurrent writes in MirroringBufferedMutator (#80)

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    281871e View commit details
    Browse the repository at this point in the history

  4. refactor: implement multiple argument operations on MirroringAsyncTab… 

    …le with specific operations rather than batch() (#75)
    @prawilny
    prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    e9751ce View commit details
    Browse the repository at this point in the history

  5. feat: implement MirroringAsyncTable#getName() (#132)

    @prawilny
    prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    fb6a71b View commit details
    Browse the repository at this point in the history

  6. feat: use Logger rather than stdout in DefaultMismatchDetector (#128)

    @prawilny
    prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    57b9e37 View commit details
    Browse the repository at this point in the history

  7. feat: synchronous writes (#88)

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    282a361 View commit details
    Browse the repository at this point in the history

  8. fix: implement heapSize method for RowCell (#111)

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    9feeae6 View commit details
    Browse the repository at this point in the history

  9. feat: FlowController accounts for memory usage (#137)

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    d5c788a View commit details
    Browse the repository at this point in the history

  10. refactor: remove Configuration as a base of MirroringConfiguration (#127 

    )
    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    ed5f4bb View commit details
    Browse the repository at this point in the history

  11. feat: MirroringAsyncBufferedMutator (#81)

    @kboroszko @prawilny
    kboroszko authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    f39c6b9 View commit details
    Browse the repository at this point in the history

  12. refactor: rename WRITE_MISMATCH to SECONDARY_WRITE_ERROR (#138)

    @prawilny
    prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    4a0f62e View commit details
    Browse the repository at this point in the history

  13. fix: BufferedMutator close() waits for all secondary flushes to finish ( 

    #110)
    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    8b75726 View commit details
    Browse the repository at this point in the history

  14. feat: 2.x reads sampling (#114)

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    dc7e0ff View commit details
    Browse the repository at this point in the history

  15. refactor: make MirroringResultScanner synchronize on itself rather th… 

    …an MirroringTable (#134)
    @prawilny
    prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    2092a3c View commit details
    Browse the repository at this point in the history

  16. ConcurrentBufferedMutator integration tests (#135)

    @prawilny
    prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    7285e81 View commit details
    Browse the repository at this point in the history

  17. feat: add synchronous MirroringConnection to 2.x (#109)

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    2b4cd4f View commit details
    Browse the repository at this point in the history

  18. fix: MirroringConnection in 2.x failed to compile (#139)

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    33011ff View commit details
    Browse the repository at this point in the history

  19. fix: fix BufferedMutator ITs (#140)

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    a9e7225 View commit details
    Browse the repository at this point in the history

  20. feat: run 1.x integration tests on MirroringConnection etc. from 2.x (#… 

    …108)
    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    80f7a4c View commit details
    Browse the repository at this point in the history

  21. feat: 2.x - rewrite Increment and Append as Put in batch (#116)

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    a2bdbb7 View commit details
    Browse the repository at this point in the history

  22. fix: fix build (#142)

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    bc4fef3 View commit details
    Browse the repository at this point in the history

  23. refactor: minor fixes after review (#117)

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    fabb55d View commit details
    Browse the repository at this point in the history

  24. feat: MirroringAsyncTable#getScanner() (#58)

    @prawilny
    prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    a22a9a7 View commit details
    Browse the repository at this point in the history

  25. test: 2.x integration tests (#112)

    @prawilny
    prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    2fdd1d0 View commit details
    Browse the repository at this point in the history

  26. feat: implement MirroringAsyncBufferedMutatorBuilder (#144)

    @prawilny
    prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    97c7436 View commit details
    Browse the repository at this point in the history

  27. feat: log rows and values in DefaultMismatchDetector (#129)

    @prawilny
    prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    22659a9 View commit details
    Browse the repository at this point in the history

  28. fix: ITs - add expected parameter to MismatchDetectors (#153)

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    d6ce67e View commit details
    Browse the repository at this point in the history

  29. fix: force Append and Increment to return results and discard that re… 

    …sult before returning it to user (#136)
    @prawilny
    prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    148c5c7 View commit details
    Browse the repository at this point in the history

  30. fix: review fixes in utils

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    550e4d6 View commit details
    Browse the repository at this point in the history

  31. fix: review fixes in BufferedMutator

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    0fcb449 View commit details
    Browse the repository at this point in the history

  32. fix: review fixes in Faillog

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    85b1fc1 View commit details
    Browse the repository at this point in the history

  33. fix: fixed reference counting

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    abb9ff9 View commit details
    Browse the repository at this point in the history

  34. fix: review fixes in FlowController

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    bd22e96 View commit details
    Browse the repository at this point in the history

  35. fix: review fixes in metrics

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    35ef562 View commit details
    Browse the repository at this point in the history

  36. fix: review fixes in verification

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    73ff6f4 View commit details
    Browse the repository at this point in the history

  37. fix: Review fixes in MirroringTable

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    845cd0c View commit details
    Browse the repository at this point in the history

  38. fix: review fixes in HBase 2.x client

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    afea24e View commit details
    Browse the repository at this point in the history

  39. fix: fixes in ITs

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    e231be4 View commit details
    Browse the repository at this point in the history

  40. feat: MirrorinAsyncTable: scan(), scanAll() (#131)

    @prawilny
    prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    666ce1f View commit details
    Browse the repository at this point in the history

  41. fix: review fixes in tests

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    7067a87 View commit details
    Browse the repository at this point in the history

  42. feat: MirroringConnection: timeout in close() and abort() (#133)

    @prawilny
    prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    8a53001 View commit details
    Browse the repository at this point in the history

  43. feat: better mismatch detection of scan results (#130)

    @prawilny
    prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    de40c73 View commit details
    Browse the repository at this point in the history

  44. feat: quickstart (#105)

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    e98ae1a View commit details
    Browse the repository at this point in the history

  45. fix: 2.x scan ITs (#158)

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    829a19b View commit details
    Browse the repository at this point in the history

  46. fix: DefaultMismatchDetector tests (#157)

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    5fa9a30 View commit details
    Browse the repository at this point in the history

  47. fix: ConcurrentBufferedMutator waits for both flushes to finish befor… 

    …e closing (#161)
    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    ca0c93c View commit details
    Browse the repository at this point in the history

  48. fix: additional minor fixes after review (#163)

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    b424ce2 View commit details
    Browse the repository at this point in the history

  49. fix: BufferedMutator review fixes (#164) 

    - Simplify #flush().
- Add javadocs.
- (sequential) Fix flush() exception handling.
- (sequential) Move error handling to a separate inner class.
    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    ee02b80 View commit details
    Browse the repository at this point in the history

  50. fix: PR fixes

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    6d7a245 View commit details
    Browse the repository at this point in the history

  51. fix: report zeroed error metrics after successful operations

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    47af2c4 View commit details
    Browse the repository at this point in the history

  52. fix: prepend MismatchDetectorCounter with Test to better reflect its … 

    …purpose
    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    40e417b View commit details
    Browse the repository at this point in the history

  53. feat: Client-side timestamping (#165)

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    8c97b6a View commit details
    Browse the repository at this point in the history

  54. fix: reduce timeout in TestBlocking to make the tests run faster

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    3e4fd67 View commit details
    Browse the repository at this point in the history

  55. fix: asyncClose -> closePrimaryAndScheduleSecondaryClose

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    0f96cdd View commit details
    Browse the repository at this point in the history

  56. fix: remove unused Batcher#throwBatchDataExceptionIfPresent

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    39703b5 View commit details
    Browse the repository at this point in the history

  57. fix: remove unused Comparators#compareRows

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    29911e0 View commit details
    Browse the repository at this point in the history

  58. fix: extract failedReads from MatchingSuccessfulReadsResults to reduc… 

    …e confusion
    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    66c89da View commit details
    Browse the repository at this point in the history

  59. feat: remove unused MirroringTracer from FailedMutationLogger

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    cbaf40e View commit details
    Browse the repository at this point in the history

  60. fix: MirroringAsyncBufferedMutator - test if failed mutation is passe… 

    …d to secondary write error consumer
    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    86c2388 View commit details
    Browse the repository at this point in the history

  61. fix: TestMirroringAsyncTableInputModification typo fix

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    5f6a479 View commit details
    Browse the repository at this point in the history

  62. fix: describe user flush() in Buffered Mutator in quickstart

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    12973f8 View commit details
    Browse the repository at this point in the history

  63. fix: MirroringBufferedMutator - move flush threshold from BufferedMut… 

    …ations to FlushSerializer
    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    3313c92 View commit details
    Browse the repository at this point in the history

  64. refactor: MirroringBufferedMutator#close() - use AccumulatedException… 

    …s insteand of List<Exception>
    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    24e7ace View commit details
    Browse the repository at this point in the history

  65. BufferedMutator - add close timeout

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    d5b7021 View commit details
    Browse the repository at this point in the history

  66. AsyncBufferedMutator - add close timeout

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    901f0dd View commit details
    Browse the repository at this point in the history

  67. fix: remove stale addSecondaryMutation comment

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    8fd792b View commit details
    Browse the repository at this point in the history

  68. fix: add a comment that addSecondaryMutation handles failed writes

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    fbdaad5 View commit details
    Browse the repository at this point in the history

  69. fix: unify implementations of flushBufferedMutatorBeforeClosing

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    de073ad View commit details
    Browse the repository at this point in the history

  70. fix: BufferedMutator - throw exceptions on close

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    b5456c4 View commit details
    Browse the repository at this point in the history

  71. fix: BufferedMutator - add comment explaining that chain of flush ope… 

    …rations is created
    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    135096b View commit details
    Browse the repository at this point in the history

  72. fix: BufferedMutator - clarify comments

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    9f72c19 View commit details
    Browse the repository at this point in the history

  73. fix: Concurrent BufferedMutator - fix throwFlushExceptionIfAvailable

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    98fd91a View commit details
    Browse the repository at this point in the history

  74. fix: explain why flush is called in Sequential BufferedMutator test

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    9aae482 View commit details
    Browse the repository at this point in the history

  75. fix: TestConcurrentMirroringBufferedMutator - make waiting for calls … 

    …explicit
    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    7a26f3a View commit details
    Browse the repository at this point in the history

  76. refactor: BufferedMutator rename scheduleFlushAll() to scheduleFlush()

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    68b75f7 View commit details
    Browse the repository at this point in the history

  77. refactor: make FlushSerializer non-static

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    5961284 View commit details
    Browse the repository at this point in the history

  78. fix: BufferedMutator - use HierarchicalReferenceCounter

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    d47a943 View commit details
    Browse the repository at this point in the history

  79. feat: Add MirroringConnection constructor taking MirroringConfiguration

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    bc3deab View commit details
    Browse the repository at this point in the history

  80. refactor: move releaseReservations to finally

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    fe9ea6c View commit details
    Browse the repository at this point in the history

  81. fix: use less convoluted example in lastFlushFutures description

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    822deaf View commit details
    Browse the repository at this point in the history

  82. fix: merge small Timeestamper files into a single file

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    6e87377 View commit details
    Browse the repository at this point in the history

  83. fix: add a comment explaining which exceptions are forwarded to the u… 

    …ser and why in SequentialMirroringBufferedMutator
    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    a7685e1 View commit details
    Browse the repository at this point in the history

  84. fix: use UnsupportedOperationException instead of RuntimeException wh… 

    …en forbidden mutation type is encountered
    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    c94e0e5 View commit details
    Browse the repository at this point in the history

  85. fix: add comment explaining why batch is complicated

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    1dbf966 View commit details
    Browse the repository at this point in the history

  86. fix: add a TODO to implement point writes without batch

    @mwalkiewicz @prawilny
    mwalkiewicz authored and prawilny committed May 11, 2022
    Configuration menu
    Copy the full SHA
    9e8ba3b View commit details
    Browse the repository at this point in the history