Skip to content

test: use ITDatastoreConceptsTest for graalvm testing #1083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 25, 2023

Conversation

kolea2
Copy link
Contributor

@kolea2 kolea2 commented May 24, 2023

Fixes #1070

This test aims to achieve the same goal (to test basic functionality in GraalVM presubmits) as googleapis/java-storage#1872.

The test used is based largely on https://github.com/googleapis/java-datastore/blob/main/samples/snippets/src/test/java/com/google/datastore/snippets/ConceptsTest.java, but refactored to run only against the Datastore backend (rather than the emulator), and moved into google-cloud-datastore so we did not have to modify the templated run config.

@kolea2 kolea2 requested review from a team as code owners May 24, 2023 15:08
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: datastore Issues related to the googleapis/java-datastore API. labels May 24, 2023
@kolea2 kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 24, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 24, 2023
Copy link
Contributor

@jainsahab jainsahab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit. a comment on top of index.yaml describing its purpose is enough.

@kolea2 kolea2 added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels May 25, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 25, 2023
@kolea2 kolea2 removed the automerge Merge the pull request once unit tests and other checks pass. label May 25, 2023
@kolea2 kolea2 merged commit 95455e0 into googleapis:main May 25, 2023
@kolea2 kolea2 deleted the graalvm-test branch May 25, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the googleapis/java-datastore API. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run graalvm tests with samples
2 participants