Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: OR query support #993

Merged
merged 8 commits into from
Mar 8, 2023
Merged

feat: OR query support #993

merged 8 commits into from
Mar 8, 2023

Conversation

kolea2
Copy link
Collaborator

@kolea2 kolea2 commented Feb 15, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: datastore Issues related to the googleapis/java-datastore API. labels Feb 15, 2023
@kolea2 kolea2 marked this pull request as ready for review March 2, 2023 16:44
@kolea2 kolea2 requested review from a team as code owners March 2, 2023 16:44
@kolea2 kolea2 added do not merge Indicates a pull request not ready for merge, due to either quality or timing. owlbot:run Add this label to trigger the Owlbot post processor. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Mar 2, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 7, 2023
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner March 7, 2023 17:09
danieljbruce
danieljbruce approved these changes Mar 7, 2023
View reviewed changes
Copy link

@danieljbruce danieljbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

google-cloud-datastore/src/test/java/com/google/cloud/datastore/it/ITDatastoreTest.java Outdated Show resolved Hide resolved
@jainsahab
Copy link
Contributor

just one minor comment, apart from that it's LGTM

@kolea2 kolea2 added owlbot:run Add this label to trigger the Owlbot post processor. automerge Merge the pull request once unit tests and other checks pass. labels Mar 8, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 8, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 99b7843 into googleapis:main Mar 8, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 8, 2023
@release-please release-please bot mentioned this pull request Mar 8, 2023
Merged
@kolea2 kolea2 deleted the or-queries branch March 8, 2023 15:55
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 8, 2023
@release-please
chore(main): release 2.14.0 (#1014)
a999a66 
🤖 I have created a release *beep* *boop*
---


## [2.14.0](https://togithub.com/googleapis/java-datastore/compare/v2.13.6...v2.14.0) (2023-03-08)


### Features

* OR query support ([#993](https://togithub.com/googleapis/java-datastore/issues/993)) ([99b7843](https://togithub.com/googleapis/java-datastore/commit/99b784332919ccc813a94ba17beaaa11b02b1c8e))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljbruce danieljbruce danieljbruce approved these changes

@jainsahab jainsahab jainsahab approved these changes

Assignees
No one assigned
Labels
api: datastore Issues related to the googleapis/java-datastore API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kolea2 @jainsahab @danieljbruce