Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make StreamableQuery#internalStream package-private to avoid documentation and prevent clirr errors #1896

Merged
merged 26 commits into from
Oct 31, 2024
Merged

fix: make StreamableQuery#internalStream package-private to avoid documentation and prevent clirr errors #1896

merged 26 commits into from
Oct 31, 2024

Conversation

MarkDuckworth
Copy link
Contributor

@MarkDuckworth MarkDuckworth commented Oct 21, 2024 •
edited
Loading

BEGIN_COMMIT_OVERRIDE
fix: make StreamableQuery#internalStream package-private to avoid documentation and prevent clirr errors

Release-As: 3.29.0
END_COMMIT_OVERRIDE

MarkDuckworth and others added 23 commits September 17, 2024 11:10
@MarkDuckworth
Refactor to support find nearest
a971555
@MarkDuckworth
Merge branch 'main' of github.com:googleapis/java-firestore into mark…
44d364d 
…duckworth/find-nearest
@MarkDuckworth
FindNearest with tests
8fe28ce
@MarkDuckworth
Cleanup and comments
151f245
@MarkDuckworth
Cleanup and addressing API breaking changes
c2da4a8
@MarkDuckworth
PR feedback and adding tests
dff55dc
@MarkDuckworth
PR comment changes
a29c6b5
@MarkDuckworth
Merge branch 'main' of github.com:googleapis/java-firestore into mark…
96a3940 
…duckworth/find-nearest
@cloud-java-bot
chore: generate libraries at Fri Sep 27 17:15:13 UTC 2024
b391efb
@MarkDuckworth
Fix dependency check
7bd43aa
@MarkDuckworth
Merge branch 'markduckworth/find-nearest' of github.com:googleapis/ja…
58756e0 
…va-firestore into markduckworth/find-nearest
@cloud-java-bot
chore: generate libraries at Fri Sep 27 17:33:40 UTC 2024
264e103
@MarkDuckworth
PR remove unnecessary override
bb83ee7
@MarkDuckworth
Merge branch 'markduckworth/find-nearest' of github.com:googleapis/ja…
31e9be2 
…va-firestore into markduckworth/find-nearest
@MarkDuckworth
PR feedback
1f61461
@MarkDuckworth
Merge branch 'main' of github.com:googleapis/java-firestore into mark…
f29120c 
…duckworth/find-nearest
@cloud-java-bot
chore: generate libraries at Tue Oct 1 19:36:20 UTC 2024
87fcff4
@MarkDuckworth
Example code
5fa33f5
@MarkDuckworth
javadoc fix
1fe96df
@MarkDuckworth
Merge branch 'main' of github.com:googleapis/java-firestore into mark…
c606e57 
…duckworth/find-nearest
@MarkDuckworth
Refactor GenericQuerySnapshot so the constructor does not accept a do…
7cfab37 
…cument set.
@MarkDuckworth
chore: make StreamableQuery#internalStream package-private to avoid d…
fb8913b 
…ocumentation and clirr errors
@MarkDuckworth
Merge branch 'main' of github.com:googleapis/java-firestore into mark…
5308d93 
…duckworth/find-nearest
@MarkDuckworth MarkDuckworth requested a review from a team as a code owner October 21, 2024 22:19
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: firestore Issues related to the googleapis/java-firestore API. labels Oct 21, 2024
@MarkDuckworth MarkDuckworth requested a review from a team as a code owner October 21, 2024 23:02
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Oct 22, 2024
@milaGGL milaGGL mentioned this pull request Oct 23, 2024
Merged
4 tasks
@MarkDuckworth MarkDuckworth added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 31, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 31, 2024
tom-andersen
tom-andersen approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@tom-andersen tom-andersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This aligns with the direction I want to move.

Note: I would have gone further, but in the exact same direction, so LGTM and let's get this merged.

@MarkDuckworth MarkDuckworth changed the title chore: make StreamableQuery#internalStream package-private to avoid documentation and clirr errors on change fix: make StreamableQuery#internalStream package-private to avoid documentation and clirr errors on change Oct 31, 2024
@MarkDuckworth MarkDuckworth changed the title fix: make StreamableQuery#internalStream package-private to avoid documentation and clirr errors on change fix: make StreamableQuery#internalStream package-private to discourage usage Oct 31, 2024
@MarkDuckworth MarkDuckworth changed the title fix: make StreamableQuery#internalStream package-private to discourage usage fix: make StreamableQuery#internalStream package-private to avoid documentation and prevent clirr errors Oct 31, 2024
@MarkDuckworth MarkDuckworth merged commit 593acc3 into main Oct 31, 2024
23 of 24 checks passed
@MarkDuckworth MarkDuckworth deleted the markduckworth/find-nearest branch October 31, 2024 16:12
@release-please release-please bot mentioned this pull request Oct 31, 2024
Merged
@MarkDuckworth MarkDuckworth added the release-please:force-run To run release-please label Nov 5, 2024
@release-please release-please bot removed the release-please:force-run To run release-please label Nov 5, 2024
@MarkDuckworth MarkDuckworth added the release-please:force-run To run release-please label Nov 5, 2024
@release-please release-please bot removed the release-please:force-run To run release-please label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-andersen tom-andersen tom-andersen approved these changes

Assignees
No one assigned
Labels
api: firestore Issues related to the googleapis/java-firestore API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MarkDuckworth @tom-andersen @yoshi-kokoro @cloud-java-bot