Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: Add style check supressions for generated StateProto.java file #2163

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

michaelpri10
Copy link
Contributor

@michaelpri10 michaelpri10 commented Sep 10, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Newly generated StateProto.java file is causing checkstyle to fail. This was autogenerated in #2068.

If you write sample code, please follow the samples format.

@michaelpri10 michaelpri10 requested review from a team as code owners September 10, 2024 16:57
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/java-pubsub API. samples Issues that are directly related to samples. labels Sep 10, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Sep 10, 2024
@michaelpri10 michaelpri10 merged commit 3d3e484 into main Sep 10, 2024
24 checks passed
@michaelpri10 michaelpri10 deleted the checkstyle-suppress branch September 10, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. samples Issues that are directly related to samples. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants