-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add pubsublite-kafka-auth module #363
Conversation
Warning: This pull request is touching the following templated files:
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
cc63734
to
014b8cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a pass. Other than the inline comments, could you add a short description for the Python script either in the README or in the file itself?
You probably need to break out the samples into a different PR after releasing the library with the change.
samples/snippets/src/main/java/pubsublite/KafkaProducerExample.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/pubsublite/KafkaProducerExample.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/pubsublite/KafkaProducerExample.java
Outdated
Show resolved
Hide resolved
pubsublite-kafka-auth/src/main/java/com/google/cloud/pubsublite/kafka/ClientParameters.java
Show resolved
Hide resolved
503d67e
to
92684c6
Compare
51c0873
to
8a1c2d8
Compare
89d098d
to
337ddec
Compare
a36b368
to
a3794e5
Compare
ecac518
to
7666f0e
Compare
9bc903c
to
a267427
Compare
9a78df7
to
10d0024
Compare
99198c1
to
819584b
Compare
35d8b28
to
4732a37
Compare
5e92ae9
to
1acf38d
Compare
0e43e4c
to
35b29ac
Compare
86c2151
to
958dfd9
Compare
f686952
to
322ac13
Compare
This allows for auth through kafka params.