Skip to content
This repository has been archived by the owner on Sep 16, 2023. It is now read-only.

feat!: remove legacy resource name #125

Merged
merged 5 commits into from
Apr 27, 2020
Merged

feat!: remove legacy resource name #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dc3711b
chore: Update gapic-generator version
yoshi-automation Apr 22, 2020
9f53088
chore: allow breaking resource name changes
chingor13 Apr 27, 2020
f540019
Merge branch 'master' into autosynth-googleapis
chingor13 Apr 27, 2020
7847bfa
chore: remove legacy resource name types
chingor13 Apr 27, 2020
4b91d65
Merge branch 'autosynth-googleapis' of github.com:googleapis/java-sec…
chingor13 Apr 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...ritycenter/src/test/java/com/google/cloud/securitycenter/v1/SecurityCenterClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1285,7 +1285,8 @@ public void updateSourceExceptionTest() throws Exception {
@Test
@SuppressWarnings("all")
public void updateSecurityMarksTest() {
SecurityMarksName name = SecurityMarksName.ofOrganizationAssetName("[ORGANIZATION]", "[ASSET]");
SecurityMarksName name =
SecurityMarksName.ofOrganizationAssetSecurityMarksName("[ORGANIZATION]", "[ASSET]");
SecurityMarks expectedResponse = SecurityMarks.newBuilder().setName(name.toString()).build();
mockSecurityCenter.addResponse(expectedResponse);

Expand Down
6 changes: 4 additions & 2 deletions ...ter/src/test/java/com/google/cloud/securitycenter/v1p1beta1/SecurityCenterClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1374,7 +1374,8 @@ public void updateSourceExceptionTest2() throws Exception {
@Test
@SuppressWarnings("all")
public void updateSecurityMarksTest() {
SecurityMarksName name = SecurityMarksName.ofOrganizationAssetName("[ORGANIZATION]", "[ASSET]");
SecurityMarksName name =
SecurityMarksName.ofOrganizationAssetSecurityMarksName("[ORGANIZATION]", "[ASSET]");
SecurityMarks expectedResponse = SecurityMarks.newBuilder().setName(name.toString()).build();
mockSecurityCenter.addResponse(expectedResponse);

Expand Down Expand Up @@ -1413,7 +1414,8 @@ public void updateSecurityMarksExceptionTest() throws Exception {
@Test
@SuppressWarnings("all")
public void updateSecurityMarksTest2() {
SecurityMarksName name = SecurityMarksName.ofOrganizationAssetName("[ORGANIZATION]", "[ASSET]");
SecurityMarksName name =
SecurityMarksName.ofOrganizationAssetSecurityMarksName("[ORGANIZATION]", "[ASSET]");
SecurityMarks expectedResponse = SecurityMarks.newBuilder().setName(name.toString()).build();
mockSecurityCenter.addResponse(expectedResponse);

Expand Down
46 changes: 43 additions & 3 deletions proto-google-cloud-securitycenter-v1/clirr-ignored-differences.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,55 @@
<method>boolean has*(*)</method>
</difference>

<!-- TODO: remove after 0.121.0 -->
<!-- TODO: remove after 0.122.0 -->
<difference>
<differenceType>7002</differenceType>
<className>com/google/cloud/securitycenter/v1/SecurityMarksName</className>
<method>java.util.List parse(java.util.List)</method>
<method>java.lang.String formatOrganizationAssetName(java.lang.String, java.lang.String)</method>
</difference>
<difference>
<differenceType>7002</differenceType>
<className>com/google/cloud/securitycenter/v1/SecurityMarksName</className>
<method>java.util.List toStrings(java.util.List)</method>
<method>java.lang.String formatOrganizationSourceFindingName(java.lang.String, java.lang.String, java.lang.String)</method>
</difference>
<difference>
<differenceType>7002</differenceType>
<className>com/google/cloud/securitycenter/v1/SecurityMarksName</className>
<method>com.google.cloud.securitycenter.v1.SecurityMarksName$Builder newOrganizationAssetBuilder()</method>
</difference>
<difference>
<differenceType>7002</differenceType>
<className>com/google/cloud/securitycenter/v1/SecurityMarksName</className>
<method>com.google.cloud.securitycenter.v1.SecurityMarksName$OrganizationSourceFindingBuilder newOrganizationSourceFindingBuilder()</method>
</difference>
<difference>
<differenceType>7002</differenceType>
<className>com/google/cloud/securitycenter/v1/SecurityMarksName</className>
<method>com.google.cloud.securitycenter.v1.SecurityMarksName ofOrganizationAssetName(java.lang.String, java.lang.String)</method>
</difference>
<difference>
<differenceType>7002</differenceType>
<className>com/google/cloud/securitycenter/v1/SecurityMarksName</className>
<method>com.google.cloud.securitycenter.v1.SecurityMarksName ofOrganizationSourceFindingName(java.lang.String, java.lang.String, java.lang.String)</method>
</difference>
<difference>
<differenceType>8001</differenceType>
<className>com/google/cloud/securitycenter/v1/SecurityMarksName$OrganizationSourceFindingBuilder</className>
</difference>
<difference>
<differenceType>8001</differenceType>
<className>com/google/cloud/securitycenter/v1/AssetSecurityMarksName*</className>
</difference>
<difference>
<differenceType>8001</differenceType>
<className>com/google/cloud/securitycenter/v1/FindingSecurityMarksName*</className>
</difference>
<difference>
<differenceType>8001</differenceType>
<className>com/google/cloud/securitycenter/v1/SecurityMarksNames</className>
</difference>
<difference>
<differenceType>8001</differenceType>
<className>com/google/cloud/securitycenter/v1/UntypedSecurityMarksName</className>
</difference>
</differences>
187 changes: 0 additions & 187 deletions ...itycenter-v1/src/main/java/com/google/cloud/securitycenter/v1/AssetSecurityMarksName.java
View file
Open in desktop

This file was deleted.

Loading