Skip to content
This repository has been archived by the owner on Sep 16, 2023. It is now read-only.

feat!: update the Iam methods to use ResourceName #74

Merged
merged 6 commits into from
Mar 10, 2020

Conversation

yihanzhen
Copy link
Contributor

  • Deprecate AssetSecurityMarksName and FindingSecurityMarksName. The functionality is ported to the new multi-pattern resource name SecurityMarksName.

  • Change SecuritymarksName to SecurityMarksName, UntypedSecuritymarksName to UntypedSecurityMarksName and SecuritymarksNames to SecurityMarksNames. The resource names with a lower m is a result of incorrect configuration.

  • Change the parameter of IAM related methods (getIamPolicy, setIamPolicy, testIamPermissions) to the more general ResourceName.

  • Delete OrganizationSourcesName. It does not represent a resource that users can directly interact with.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 24, 2020
@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #74 into master will decrease coverage by 0.33%.
The diff coverage is 75.52%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #74      +/-   ##
============================================
- Coverage     77.90%   77.56%   -0.34%     
+ Complexity      423      370      -53     
============================================
  Files            18       18              
  Lines          3679     3459     -220     
  Branches         55       19      -36     
============================================
- Hits           2866     2683     -183     
+ Misses          750      717      -33     
+ Partials         63       59       -4     
Impacted Files Coverage Δ Complexity Δ
...loud/securitycenter/v1/SecurityCenterSettings.java 10.76% <0.00%> (ø) 2.00 <0.00> (ø)
...oud/securitycenter/v1/stub/SecurityCenterStub.java 3.84% <0.00%> (ø) 1.00 <0.00> (ø)
.../cloud/securitycenter/v1/SecurityCenterClient.java 70.00% <53.12%> (+0.45%) 54.00 <23.00> (-13.00) ⬆️
...ritycenter/v1/stub/SecurityCenterStubSettings.java 81.92% <88.23%> (-0.17%) 28.00 <4.00> (-1.00)
...securitycenter/v1/stub/GrpcSecurityCenterStub.java 96.14% <100.00%> (-0.32%) 25.00 <6.00> (-1.00)
...itycenter/v1beta1/stub/GrpcSecurityCenterStub.java 96.14% <0.00%> (-0.32%) 25.00% <0.00%> (-1.00%)
...ycenter/v1p1beta1/stub/GrpcSecurityCenterStub.java 96.73% <0.00%> (-0.28%) 30.00% <0.00%> (-1.00%)
...enter/v1beta1/stub/SecurityCenterStubSettings.java 81.92% <0.00%> (-0.17%) 28.00% <0.00%> (-1.00%)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a6d921...0e66b01. Read the comment docs.

@yihanzhen yihanzhen requested a review from chingor13 February 24, 2020 21:19
@chingor13 chingor13 changed the title feat: update the implementation and usage of resource name helper classes feat!: update the implementation and usage of resource name helper classes Feb 24, 2020
@yihanzhen yihanzhen force-pushed the migration-securitycenter branch from 6a21940 to 0e66b01 Compare March 9, 2020 21:44
@chingor13 chingor13 changed the title feat!: update the implementation and usage of resource name helper classes feat!: update the Iam methods to use ResourceName Mar 10, 2020
@chingor13 chingor13 merged commit cc5c709 into googleapis:master Mar 10, 2020
@release-please release-please bot mentioned this pull request Mar 10, 2020
@yihanzhen
Copy link
Contributor Author

Thanks Jeff!

gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 10, 2020
🤖 I have created a release \*beep\* \*boop\* 
---
## [0.120.0](https://www.github.com/googleapis/java-securitycenter/compare/v0.119.0...v0.120.0) (2020-03-10)


### ⚠ BREAKING CHANGES

* update the Iam methods to use ResourceName (#74)

### Features

* update the Iam methods to use ResourceName ([#74](https://www.github.com/googleapis/java-securitycenter/issues/74)) ([cc5c709](https://www.github.com/googleapis/java-securitycenter/commit/cc5c709eb35228fe8093b611ef8ede4f2bf76f7c))
* **v1:** add Notifications API ([#78](https://www.github.com/googleapis/java-securitycenter/issues/78)) ([7909b8e](https://www.github.com/googleapis/java-securitycenter/commit/7909b8e59bbfcdf96512034298e9315e9603d2cd))


### Dependencies

* update core dependencies to v1.54.0 ([#76](https://www.github.com/googleapis/java-securitycenter/issues/76)) ([a0fdb5c](https://www.github.com/googleapis/java-securitycenter/commit/a0fdb5c96c17ceea535cf935b2e8d26052936a02))
* update dependency com.google.protobuf:protobuf-java to v3.11.4 ([ad734b5](https://www.github.com/googleapis/java-securitycenter/commit/ad734b57d316e70f338069912ca1bc3599935f24))
* update dependency io.grpc:grpc-bom to v1.27.1 ([6a6d921](https://www.github.com/googleapis/java-securitycenter/commit/6a6d9214f86d63058360d55cf511cd29c398d77b))
* update dependency io.grpc:grpc-bom to v1.27.2 ([#75](https://www.github.com/googleapis/java-securitycenter/issues/75)) ([29bdbae](https://www.github.com/googleapis/java-securitycenter/commit/29bdbae5c7c7227a3364f2239dcc52d48c7b8e50))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants