This repository has been archived by the owner on Sep 16, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
feat!: update the Iam methods to use ResourceName #74
Merged
chingor13
merged 6 commits into
googleapis:master
from
yihanzhen:migration-securitycenter
Mar 10, 2020
Merged
feat!: update the Iam methods to use ResourceName #74
chingor13
merged 6 commits into
googleapis:master
from
yihanzhen:migration-securitycenter
Mar 10, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into migration-securitycenter
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Feb 24, 2020
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
============================================
- Coverage 77.90% 77.56% -0.34%
+ Complexity 423 370 -53
============================================
Files 18 18
Lines 3679 3459 -220
Branches 55 19 -36
============================================
- Hits 2866 2683 -183
+ Misses 750 717 -33
+ Partials 63 59 -4
Continue to review full report at Codecov.
|
chingor13
changed the title
feat: update the implementation and usage of resource name helper classes
feat!: update the implementation and usage of resource name helper classes
Feb 24, 2020
chingor13
suggested changes
Feb 24, 2020
...center/src/main/java/com/google/cloud/securitycenter/v1/stub/SecurityCenterStubSettings.java
Outdated
Show resolved
Hide resolved
yihanzhen
force-pushed
the
migration-securitycenter
branch
from
March 9, 2020 21:44
6a21940
to
0e66b01
Compare
chingor13
changed the title
feat!: update the implementation and usage of resource name helper classes
feat!: update the Iam methods to use ResourceName
Mar 10, 2020
chingor13
approved these changes
Mar 10, 2020
Merged
Thanks Jeff! |
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 10, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [0.120.0](https://www.github.com/googleapis/java-securitycenter/compare/v0.119.0...v0.120.0) (2020-03-10) ### ⚠ BREAKING CHANGES * update the Iam methods to use ResourceName (#74) ### Features * update the Iam methods to use ResourceName ([#74](https://www.github.com/googleapis/java-securitycenter/issues/74)) ([cc5c709](https://www.github.com/googleapis/java-securitycenter/commit/cc5c709eb35228fe8093b611ef8ede4f2bf76f7c)) * **v1:** add Notifications API ([#78](https://www.github.com/googleapis/java-securitycenter/issues/78)) ([7909b8e](https://www.github.com/googleapis/java-securitycenter/commit/7909b8e59bbfcdf96512034298e9315e9603d2cd)) ### Dependencies * update core dependencies to v1.54.0 ([#76](https://www.github.com/googleapis/java-securitycenter/issues/76)) ([a0fdb5c](https://www.github.com/googleapis/java-securitycenter/commit/a0fdb5c96c17ceea535cf935b2e8d26052936a02)) * update dependency com.google.protobuf:protobuf-java to v3.11.4 ([ad734b5](https://www.github.com/googleapis/java-securitycenter/commit/ad734b57d316e70f338069912ca1bc3599935f24)) * update dependency io.grpc:grpc-bom to v1.27.1 ([6a6d921](https://www.github.com/googleapis/java-securitycenter/commit/6a6d9214f86d63058360d55cf511cd29c398d77b)) * update dependency io.grpc:grpc-bom to v1.27.2 ([#75](https://www.github.com/googleapis/java-securitycenter/issues/75)) ([29bdbae](https://www.github.com/googleapis/java-securitycenter/commit/29bdbae5c7c7227a3364f2239dcc52d48c7b8e50)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate
AssetSecurityMarksName
andFindingSecurityMarksName
. The functionality is ported to the new multi-pattern resource nameSecurityMarksName
.Change
SecuritymarksName
toSecurityMarksName
,UntypedSecuritymarksName
toUntypedSecurityMarksName
andSecuritymarksNames
toSecurityMarksNames
. The resource names with a lowerm
is a result of incorrect configuration.Change the parameter of IAM related methods (
getIamPolicy
,setIamPolicy
,testIamPermissions
) to the more generalResourceName
.Delete
OrganizationSourcesName
. It does not represent a resource that users can directly interact with.