Skip to content
This repository has been archived by the owner on Sep 16, 2023. It is now read-only.

feat: Added contacts field to findings attributes, specifying Essential Contacts defined at org, folder or project level within a GCP org #865

Merged
merged 4 commits into from
Jul 13, 2022
Merged

feat: Added contacts field to findings attributes, specifying Essential Contacts defined at org, folder or project level within a GCP org #865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
27633e5
feat: Added contacts field to findings attributes, specifying Essenti…
gcf-owl-bot[bot] Jul 4, 2022
49623bc
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jul 4, 2022
4669e54
add scc-secrets, excluded samples.cfg from owlbot changes and fixed P…
Sita04 Jul 13, 2022
9fb8cd3
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jul 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .kokoro/presubmit/samples.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,5 @@ env_vars: {

env_vars: {
key: "SECRET_MANAGER_KEYS"
value: "java-docs-samples-service-account"
value: "java-docs-samples-service-account,java-scc-samples-secrets"
}
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,20 +60,20 @@ If you are using Maven without BOM, add this to your dependencies:
If you are using Gradle 5.x or later, add this to your dependencies

```Groovy
implementation platform('com.google.cloud:libraries-bom:25.4.0')
implementation platform('com.google.cloud:libraries-bom:26.0.0')

implementation 'com.google.cloud:google-cloud-securitycenter'
```
If you are using Gradle without BOM, add this to your dependencies

```Groovy
implementation 'com.google.cloud:google-cloud-securitycenter:2.7.0'
implementation 'com.google.cloud:google-cloud-securitycenter:2.7.1'
```

If you are using SBT, add this to your dependencies

```Scala
libraryDependencies += "com.google.cloud" % "google-cloud-securitycenter" % "2.7.0"
libraryDependencies += "com.google.cloud" % "google-cloud-securitycenter" % "2.7.1"
```

## Authentication
Expand Down
9 changes: 9 additions & 0 deletions ...er/src/test/java/com/google/cloud/securitycenter/v1/SecurityCenterClientHttpJsonTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,7 @@ public void createFindingTest() throws Exception {
.addAllConnections(new ArrayList<Connection>())
.setMuteInitiator("muteInitiator1395645462")
.addAllProcesses(new ArrayList<Process>())
.putAllContacts(new HashMap<String, ContactDetails>())
.addAllCompliances(new ArrayList<Compliance>())
.setDescription("description-1724546052")
.setExfiltration(Exfiltration.newBuilder().build())
Expand Down Expand Up @@ -388,6 +389,7 @@ public void createFindingTest2() throws Exception {
.addAllConnections(new ArrayList<Connection>())
.setMuteInitiator("muteInitiator1395645462")
.addAllProcesses(new ArrayList<Process>())
.putAllContacts(new HashMap<String, ContactDetails>())
.addAllCompliances(new ArrayList<Compliance>())
.setDescription("description-1724546052")
.setExfiltration(Exfiltration.newBuilder().build())
Expand Down Expand Up @@ -2775,6 +2777,7 @@ public void setFindingStateTest() throws Exception {
.addAllConnections(new ArrayList<Connection>())
.setMuteInitiator("muteInitiator1395645462")
.addAllProcesses(new ArrayList<Process>())
.putAllContacts(new HashMap<String, ContactDetails>())
.addAllCompliances(new ArrayList<Compliance>())
.setDescription("description-1724546052")
.setExfiltration(Exfiltration.newBuilder().build())
Expand Down Expand Up @@ -2851,6 +2854,7 @@ public void setFindingStateTest2() throws Exception {
.addAllConnections(new ArrayList<Connection>())
.setMuteInitiator("muteInitiator1395645462")
.addAllProcesses(new ArrayList<Process>())
.putAllContacts(new HashMap<String, ContactDetails>())
.addAllCompliances(new ArrayList<Compliance>())
.setDescription("description-1724546052")
.setExfiltration(Exfiltration.newBuilder().build())
Expand Down Expand Up @@ -2925,6 +2929,7 @@ public void setMuteTest() throws Exception {
.addAllConnections(new ArrayList<Connection>())
.setMuteInitiator("muteInitiator1395645462")
.addAllProcesses(new ArrayList<Process>())
.putAllContacts(new HashMap<String, ContactDetails>())
.addAllCompliances(new ArrayList<Compliance>())
.setDescription("description-1724546052")
.setExfiltration(Exfiltration.newBuilder().build())
Expand Down Expand Up @@ -2999,6 +3004,7 @@ public void setMuteTest2() throws Exception {
.addAllConnections(new ArrayList<Connection>())
.setMuteInitiator("muteInitiator1395645462")
.addAllProcesses(new ArrayList<Process>())
.putAllContacts(new HashMap<String, ContactDetails>())
.addAllCompliances(new ArrayList<Compliance>())
.setDescription("description-1724546052")
.setExfiltration(Exfiltration.newBuilder().build())
Expand Down Expand Up @@ -3323,6 +3329,7 @@ public void updateFindingTest() throws Exception {
.addAllConnections(new ArrayList<Connection>())
.setMuteInitiator("muteInitiator1395645462")
.addAllProcesses(new ArrayList<Process>())
.putAllContacts(new HashMap<String, ContactDetails>())
.addAllCompliances(new ArrayList<Compliance>())
.setDescription("description-1724546052")
.setExfiltration(Exfiltration.newBuilder().build())
Expand Down Expand Up @@ -3355,6 +3362,7 @@ public void updateFindingTest() throws Exception {
.addAllConnections(new ArrayList<Connection>())
.setMuteInitiator("muteInitiator1395645462")
.addAllProcesses(new ArrayList<Process>())
.putAllContacts(new HashMap<String, ContactDetails>())
.addAllCompliances(new ArrayList<Compliance>())
.setDescription("description-1724546052")
.setExfiltration(Exfiltration.newBuilder().build())
Expand Down Expand Up @@ -3412,6 +3420,7 @@ public void updateFindingExceptionTest() throws Exception {
.addAllConnections(new ArrayList<Connection>())
.setMuteInitiator("muteInitiator1395645462")
.addAllProcesses(new ArrayList<Process>())
.putAllContacts(new HashMap<String, ContactDetails>())
.addAllCompliances(new ArrayList<Compliance>())
.setDescription("description-1724546052")
.setExfiltration(Exfiltration.newBuilder().build())
Expand Down
7 changes: 7 additions & 0 deletions ...ritycenter/src/test/java/com/google/cloud/securitycenter/v1/SecurityCenterClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,7 @@ public void createFindingTest() throws Exception {
.addAllConnections(new ArrayList<Connection>())
.setMuteInitiator("muteInitiator1395645462")
.addAllProcesses(new ArrayList<Process>())
.putAllContacts(new HashMap<String, ContactDetails>())
.addAllCompliances(new ArrayList<Compliance>())
.setDescription("description-1724546052")
.setExfiltration(Exfiltration.newBuilder().build())
Expand Down Expand Up @@ -375,6 +376,7 @@ public void createFindingTest2() throws Exception {
.addAllConnections(new ArrayList<Connection>())
.setMuteInitiator("muteInitiator1395645462")
.addAllProcesses(new ArrayList<Process>())
.putAllContacts(new HashMap<String, ContactDetails>())
.addAllCompliances(new ArrayList<Compliance>())
.setDescription("description-1724546052")
.setExfiltration(Exfiltration.newBuilder().build())
Expand Down Expand Up @@ -2546,6 +2548,7 @@ public void setFindingStateTest() throws Exception {
.addAllConnections(new ArrayList<Connection>())
.setMuteInitiator("muteInitiator1395645462")
.addAllProcesses(new ArrayList<Process>())
.putAllContacts(new HashMap<String, ContactDetails>())
.addAllCompliances(new ArrayList<Compliance>())
.setDescription("description-1724546052")
.setExfiltration(Exfiltration.newBuilder().build())
Expand Down Expand Up @@ -2618,6 +2621,7 @@ public void setFindingStateTest2() throws Exception {
.addAllConnections(new ArrayList<Connection>())
.setMuteInitiator("muteInitiator1395645462")
.addAllProcesses(new ArrayList<Process>())
.putAllContacts(new HashMap<String, ContactDetails>())
.addAllCompliances(new ArrayList<Compliance>())
.setDescription("description-1724546052")
.setExfiltration(Exfiltration.newBuilder().build())
Expand Down Expand Up @@ -2688,6 +2692,7 @@ public void setMuteTest() throws Exception {
.addAllConnections(new ArrayList<Connection>())
.setMuteInitiator("muteInitiator1395645462")
.addAllProcesses(new ArrayList<Process>())
.putAllContacts(new HashMap<String, ContactDetails>())
.addAllCompliances(new ArrayList<Compliance>())
.setDescription("description-1724546052")
.setExfiltration(Exfiltration.newBuilder().build())
Expand Down Expand Up @@ -2757,6 +2762,7 @@ public void setMuteTest2() throws Exception {
.addAllConnections(new ArrayList<Connection>())
.setMuteInitiator("muteInitiator1395645462")
.addAllProcesses(new ArrayList<Process>())
.putAllContacts(new HashMap<String, ContactDetails>())
.addAllCompliances(new ArrayList<Compliance>())
.setDescription("description-1724546052")
.setExfiltration(Exfiltration.newBuilder().build())
Expand Down Expand Up @@ -3036,6 +3042,7 @@ public void updateFindingTest() throws Exception {
.addAllConnections(new ArrayList<Connection>())
.setMuteInitiator("muteInitiator1395645462")
.addAllProcesses(new ArrayList<Process>())
.putAllContacts(new HashMap<String, ContactDetails>())
.addAllCompliances(new ArrayList<Compliance>())
.setDescription("description-1724546052")
.setExfiltration(Exfiltration.newBuilder().build())
Expand Down
5 changes: 4 additions & 1 deletion owlbot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,4 +64,7 @@
s.move(library)

s.remove_staging_dirs()
java.common_templates()

java.common_templates(excludes=[
'.kokoro/presubmit/samples.cfg'
])
Loading