Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fmt-maven-plugin versioning #650

Open
JesseLovelace opened this issue Aug 21, 2023 · 2 comments
Open

fmt-maven-plugin versioning #650

JesseLovelace opened this issue Aug 21, 2023 · 2 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: docs Improvement to the documentation for an API. type: process A process-related concern. May include testing, release, or the like.

Comments

@JesseLovelace
Copy link

It was raised in googleapis/java-storage-nio#1069 that the fmt-maven-plugin has moved to com.spotify.fmt

It looks like the fmt-maven-plugin dependency is pinned to specific version due to Java 8 compatibility. I believe that would mean we can't actually depend on com.spotify.fmt instead.

Is that the case, or would there be any way to move the dependency?

If we can't change the dependency feel free to close this, just wanted to make sure it's documented!
@JesseLovelace JesseLovelace mentioned this issue Aug 21, 2023
Closed
@blakeli0 blakeli0 added priority: p2 Moderately-important priority. Fix may not be included in next release. type: docs Improvement to the documentation for an API. type: process A process-related concern. May include testing, release, or the like. labels Aug 25, 2023
@blakeli0
Copy link

I think we could change it to the Spotify one by using the 2.9.x release based on their README, do we think it's worth it to switch to the Spotify plugin @suztomo?

@suztomo suztomo added the priority: p3 Desirable enhancement or fix. May not be included in next release. label Aug 31, 2023
@suztomo
Copy link
Member

suztomo commented Aug 31, 2023

P3 nice to have feature. We also upgraded the release build to use Java 17. If only use format task in Java 17 only then upgrade should be easy.

@suztomo suztomo removed the priority: p2 Moderately-important priority. Fix may not be included in next release. label Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: docs Improvement to the documentation for an API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@suztomo @blakeli0 @JesseLovelace