Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support customer managed instance configurations #1742

Merged
merged 56 commits into from
Sep 29, 2022

Conversation

rajatbhatta
Copy link
Contributor

@rajatbhatta rajatbhatta commented Mar 9, 2022

This PR implements the functionality for CMMR Phase 2. Here we do the following:

  • Adds support for new fields optionalReplicas, baseConfig, labels, etag, reconciling, state, configType in InstanceConfigInfo class.

  • Adds Builder class for InstanceConfigInfo.

  • Adds an InstanceConfigField class (which extends from FieldMask). This can be used to specify a subset of fields to be modified during update operation.

  • Adds Builder class for InstanceConfig.

  • Changes to Rpc interface/class to add support for Create, Update and Delete instance config operations.

  • Adds createInstanceConfig, updateInstanceConfig, and deleteInstanceConfig methods to InstanceAdminClient interface.

  • Provide implementations for createInstanceConfig, updateInstanceConfig, and deleteInstanceConfig methods in InstanceAdminClientImpl class. These methods call the corresponding Rpc methods, which are responsible for making the Rpc calls.

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Mar 9, 2022
@generated-files-bot
Copy link

generated-files-bot bot commented Mar 9, 2022

Warning: This pull request is touching the following templated files:

  • proto-google-cloud-spanner-admin-instance-v1/src/main/proto/google/spanner/admin/instance/v1/spanner_instance_admin.proto

@snippet-bot
Copy link

snippet-bot bot commented Mar 9, 2022

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@rajatbhatta rajatbhatta added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 24, 2022
@rajatbhatta rajatbhatta requested a review from ansh0l March 24, 2022 09:30
@rajatbhatta rajatbhatta marked this pull request as ready for review March 24, 2022 09:32
@rajatbhatta rajatbhatta requested review from a team as code owners March 24, 2022 09:32
@rajatbhatta rajatbhatta marked this pull request as draft March 24, 2022 09:34
@rajatbhatta rajatbhatta self-assigned this Mar 31, 2022
while creating instance config.
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label May 2, 2022
@rajatbhatta
Copy link
Contributor Author

Hi @thiagotnunes @olavloite : I've added support (both implementation and tests) for ListInstanceConfigOperations as well to this PR. Can you please review changes since previous code review? Thank you!

Copy link
Collaborator

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last changes also look good to me. I assume that we will add end-to-end tests either in a separate PR, or later in this PR once it is enabled on the backend?

@rajatbhatta
Copy link
Contributor Author

The last changes also look good to me. I assume that we will add end-to-end tests either in a separate PR, or later in this PR once it is enabled on the backend?

Thanks for the review! Yes, we'll add end-to-end tests in a separate PR, along with the samples. We'll be writing integration tests using those samples (like in other clients).

@rajatbhatta rajatbhatta removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 19, 2022
@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 21, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 21, 2022
@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 21, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 21, 2022
@rajatbhatta rajatbhatta changed the title feat: [DO NOT MERGE] support customer managed instance configurations feat: support customer managed instance configurations Sep 21, 2022
@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 29, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 29, 2022
@rajatbhatta rajatbhatta merged commit c1c805c into googleapis:main Sep 29, 2022
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 30, 2022
🤖 I have created a release *beep* *boop*
---


## [6.31.0](https://togithub.com/googleapis/java-spanner/compare/v6.30.2...v6.31.0) (2022-09-29)


### Features

* Support customer managed instance configurations ([#1742](https://togithub.com/googleapis/java-spanner/issues/1742)) ([c1c805c](https://togithub.com/googleapis/java-spanner/commit/c1c805cf6e9c00f2d6796627d919338be1a0599a))


### Dependencies

* Update dependency com.google.cloud:google-cloud-trace to v2.3.4 ([#2027](https://togithub.com/googleapis/java-spanner/issues/2027)) ([14890ed](https://togithub.com/googleapis/java-spanner/commit/14890ed8e0df99eba7c2521a196132c78054b6ed))
* Update dependency com.google.cloud:google-cloud-trace to v2.3.5 ([#2083](https://togithub.com/googleapis/java-spanner/issues/2083)) ([cef4e0a](https://togithub.com/googleapis/java-spanner/commit/cef4e0ada98ab65020f32836fc0c8ab1ee0c7eed))
* Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.14 ([#2030](https://togithub.com/googleapis/java-spanner/issues/2030)) ([04b59ff](https://togithub.com/googleapis/java-spanner/commit/04b59ff8a1efaa32082aa4e9567d90b5956810c6))
* Update dependency org.json:json to v20220924 ([#2035](https://togithub.com/googleapis/java-spanner/issues/2035)) ([a26a14a](https://togithub.com/googleapis/java-spanner/commit/a26a14a94ac3ca6cd7eabce6826cce3dde27ea66))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants