test: fix mock server ARRAY<BYTES> parameter cast #2344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent change that made decoding BYTES and ARRAY<BYTES> lazy did not update all code paths in the mock Spanner server that is used for testing. This meant that tests that tried to use ARRAY<BYTES> query parameters would run into a ClassCastException. This problem only occurs in (internal) test code and does not affect user code.
product-auto-label
bot
added
the
api: spanner
arpan14
approved these changes
Mar 23, 2023
| ``` | ||
|
|
||
| If you are using SBT, add this to your dependencies: | ||
|
|
||
| ```Scala | ||
| libraryDependencies += "com.google.cloud" % "google-cloud-spanner" % "6.36.1" | ||
| libraryDependencies += "com.google.cloud" % "google-cloud-spanner" % "6.38.0" |
There was a problem hiding this comment.
Query - Are these versions manually updated? Or is there an automated way of maintaining this?
There was a problem hiding this comment.
Those are automatic updates from the OwlBot (see 9ce2e8b)
arpan14
pushed a commit
to arpan14/java-spanner
that referenced
this pull request
Apr 28, 2023
* test: fix mock server ARRAY<BYTES> parameter cast The recent change that made decoding BYTES and ARRAY<BYTES> lazy did not update all code paths in the mock Spanner server that is used for testing. This meant that tests that tried to use ARRAY<BYTES> query parameters would run into a ClassCastException. This problem only occurs in (internal) test code and does not affect user code. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent change that made decoding BYTES and ARRAY lazy did not update all code paths in the mock Spanner server that is used for testing. This meant that tests that tried to use ARRAY query parameters would run into a ClassCastException. This problem only occurs in (internal) test code and does not affect user code.