chore: fix session acquire timeout test #2793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test for session acquire timeout did not actually do what it was supposed to do, as it did not check that a timeout was actually registered. This again also caused it to busy-wait for 5 seconds to times (MinSessions=0 and MinSessions=1). This fixes both the actual test, and reduces the overall test time by about 10 seconds.
product-auto-label
bot
added
size: xs
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
harshachinta
reviewed
Feb 6, 2024
google-cloud-spanner/src/test/java/com/google/cloud/spanner/SessionPoolTest.java
Show resolved
Hide resolved
harshachinta
reviewed
Feb 6, 2024
google-cloud-spanner/src/test/java/com/google/cloud/spanner/SessionPoolTest.java
Show resolved
Hide resolved
product-auto-label
bot
added
size: s
harshachinta
approved these changes
Feb 6, 2024
olavloite
added
the
automerge
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test for session acquire timeout did not actually do what it was supposed to do, as it did not check that a timeout was actually registered. This again also caused it to busy-wait for 5 seconds to times (MinSessions=0 and MinSessions=1). This fixes both the actual test, and reduces the overall test time by about 10 seconds.