Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(samples): add sample for spanner editions #3304

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

rahul2393
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@rahul2393 rahul2393 requested review from a team as code owners August 27, 2024 05:19
Copy link

snippet-bot bot commented Aug 27, 2024

Here is the summary of changes.

You are about to add 2 region tags.
You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. labels Aug 27, 2024
@rahul2393 rahul2393 changed the title Spanner editions sample chore(samples): add sample for spanner editions Aug 27, 2024
Copy link
Contributor

@nithinsujir nithinsujir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edition sample change lgtm. (There are other unrelated changes which I've not reviewed)

@rahul2393
Copy link
Contributor Author

Other changes are mostly related to running mvn:format

@rahul2393 rahul2393 added the automerge Merge the pull request once unit tests and other checks pass. label Sep 16, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 00c54d9 into main Sep 16, 2024
33 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 16, 2024
@gcf-merge-on-green gcf-merge-on-green bot deleted the spanner-editions-sample branch September 16, 2024 07:18
lqiu96 pushed a commit that referenced this pull request Sep 19, 2024
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/java-spanner/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the [samples format](
https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants