Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spanner): add jdbc support for external hosts #3536

Merged
merged 5 commits into from
Dec 16, 2024
Merged

feat(spanner): add jdbc support for external hosts #3536

merged 5 commits into from
Dec 16, 2024

Conversation

sagnghos
Copy link
Contributor

@sagnghos sagnghos commented Dec 9, 2024 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@sagnghos sagnghos requested a review from a team as a code owner December 9, 2024 05:53
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/java-spanner API. labels Dec 9, 2024
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 10, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 10, 2024
@sagnghos sagnghos requested a review from a team as a code owner December 11, 2024 11:43
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: s Pull request size is small. labels Dec 11, 2024
@generated-files-bot Generated Files Bot
Copy link

Warning: This pull request is touching the following templated files:

  • .github/workflows/ci.yaml
  • .kokoro/presubmit/java11.cfg

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Dec 11, 2024
@sagnghos sagnghos force-pushed the sanghos-jdbc-support branch from 6f3cb54 to a24b6f0 Compare December 11, 2024 11:51
@sagnghos sagnghos force-pushed the sanghos-jdbc-support branch from a24b6f0 to f2827f6 Compare December 13, 2024 12:34
@sagnghos sagnghos requested a review from olavloite December 13, 2024 12:49
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 13, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 13, 2024
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 16, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 16, 2024
@rahul2393 rahul2393 merged commit 801346a into googleapis:main Dec 16, 2024
32 checks passed
@release-please release-please bot mentioned this pull request Dec 16, 2024
Open
@sagnghos sagnghos deleted the sanghos-jdbc-support branch December 16, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite Awaiting requested review from olavloite

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sagnghos @olavloite @rahul2393 @yoshi-kokoro