Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add sample for asymmetric autoscaling instances #3562

Merged
merged 2 commits into from
Jan 29, 2025
Merged

feat: Add sample for asymmetric autoscaling instances #3562

merged 2 commits into from
Jan 29, 2025

Conversation

hibiken
Copy link
Contributor

@hibiken hibiken commented Dec 16, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • [] Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

If you write sample code, please follow the samples format.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. labels Dec 16, 2024
@hibiken hibiken marked this pull request as ready for review January 27, 2025 18:05
@hibiken hibiken requested review from a team as code owners January 27, 2025 18:05
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Jan 27, 2025 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@hibiken hibiken closed this Jan 27, 2025
@hibiken hibiken reopened this Jan 27, 2025
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 28, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 28, 2025
@hibiken hibiken requested a review from a team as a code owner January 29, 2025 17:03
@rahul2393 rahul2393 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Jan 29, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 29, 2025
@gcf-merge-on-green gcf-merge-on-green bot merged commit 3584b81 into googleapis:main Jan 29, 2025
31 of 32 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 29, 2025
@release-please release-please bot mentioned this pull request Jan 29, 2025
Merged
svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull request Feb 3, 2025
@github-cash-renovate-jvm-2 @svc-squareup-copybara
This PR contains the following updates:
caa4684 
| Package | Type | Package file | Manager | Update | Change |
|---|---|---|---|---|---|
|
[com.google.cloud:google-cloud-spanner](https://github.com/googleapis/java-spanner)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`6.85.0` -> `6.86.0` |

---

### Release Notes

<details>
<summary>googleapis/java-spanner
(com.google.cloud:google-cloud-spanner)</summary>

###
[`v6.86.0`](https://github.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#6860-2025-01-31)

##### Features

- Add sample for asymmetric autoscaling instances
([#&#8203;3562](googleapis/java-spanner#3562))
([3584b81](googleapis/java-spanner@3584b81))
- Support graph and pipe queries in Connection API
([#&#8203;3586](googleapis/java-spanner#3586))
([71c3063](googleapis/java-spanner@71c3063))

##### Bug Fixes

- Always add instance-id for built-in metrics
([#&#8203;3612](googleapis/java-spanner#3612))
([705b627](googleapis/java-spanner@705b627))
- **deps:** Update the Java code generator (gapic-generator-java) to
2.51.1
([3e27251](googleapis/java-spanner@3e27251))
- **deps:** Update the Java code generator (gapic-generator-java) to
2.52.0
([bf69673](googleapis/java-spanner@bf69673))
- **spanner:** Moved mTLSContext configurator from builder to construtor
([#&#8203;3605](googleapis/java-spanner#3605))
([ac7c30b](googleapis/java-spanner@ac7c30b))

##### Dependencies

- Update dependency com.google.cloud:sdk-platform-java-config to v3.42.0
([#&#8203;3616](googleapis/java-spanner#3616))
([2ea59f0](googleapis/java-spanner@2ea59f0))
- Update dependency io.opentelemetry:opentelemetry-bom to v1.46.0
([#&#8203;3530](googleapis/java-spanner#3530))
([d505850](googleapis/java-spanner@d505850))

##### Documentation

- Clarify how async updates can overtake each other
([#&#8203;3581](googleapis/java-spanner#3581))
([1be250f](googleapis/java-spanner@1be250f))
- Fix typo timzeone -> timezone
([bf69673](googleapis/java-spanner@bf69673))
- Fixed parameter arguments for AbstractResultSet's Listener's on
TransactionMetadata doc
([#&#8203;3602](googleapis/java-spanner#3602))
([1f143a4](googleapis/java-spanner@1f143a4))
- **samples:** Add samples and tests for change streams transaction
exclusion
([#&#8203;3098](googleapis/java-spanner#3098))
([1f81600](googleapis/java-spanner@1f81600))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am
every weekday" in timezone Australia/Melbourne, Automerge - At any time
(no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

GitOrigin-RevId: ae3d6e05ea6da84db9faf0e473fd148d6ad36a6e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahul2393 rahul2393 rahul2393 approved these changes

Assignees

@bourgeoisor bourgeoisor

Labels
api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hibiken @rahul2393 @bourgeoisor @yoshi-kokoro