Skip to content

Commit

Permalink
chore: fix samples pom.xml issues (#2660)
Browse files Browse the repository at this point in the history
* Close dependency element for `storage_install_with_bom`
* Remove release please comment for storage control from `storage_install_without_bom`. Instead, allow renovate-bot to update when the version is available in maven central.
* remove duplicate declaration of `google-cloud-storage-control` in install-without-bom/pom.xml
  • Loading branch information
BenWhitehead authored Aug 5, 2024
1 parent 9af865c commit 48e7a4c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 8 deletions.
10 changes: 2 additions & 8 deletions samples/install-without-bom/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,12 @@
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-storage</artifactId>
<version>2.40.1</version>
<version>2.41.0</version>
</dependency>
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-storage-control</artifactId>
<version>2.41.0</version><!-- {x-version-update:google-cloud-storage:current} -->
<version>2.41.0</version>
</dependency>
<!-- [END storage_install_without_bom] -->

Expand Down Expand Up @@ -69,12 +69,6 @@
<version>1.132.0</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-storage-control</artifactId>
<version>2.40.1</version>
<scope>compile</scope>
</dependency>
</dependencies>

<!-- compile and run all snippet tests -->
Expand Down
2 changes: 2 additions & 0 deletions samples/snippets/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -79,5 +79,7 @@
<version>1.132.0</version>
<scope>test</scope>
</dependency>
<!-- [START storage_install_with_bom] -->
</dependencies>
<!-- [END storage_install_with_bom] -->
</project>

0 comments on commit 48e7a4c

Please sign in to comment.