pr comments

googleapis · Jan 10, 2025 · 6ed185b · 6ed185b
1 parent 2292dce
commit 6ed185b
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/samples/snippets/src/main/java/com/example/storage/QuickstartOpenTelemetrySample.java b/samples/snippets/src/main/java/com/example/storage/QuickstartOpenTelemetrySample.java
@@ -34,7 +34,7 @@
 // [START storage_enable_otel_tracing]
 public class QuickstartOpenTelemetrySample {
   public static void main(String... args) throws Exception {
-    SpanExporter exporter = TraceExporter.createWithDefaultConfiguration();
+    SpanExporter spanExporter = TraceExporter.createWithDefaultConfiguration();
     TextMapPropagator propagators = TextMapPropagator.composite(
         W3CTraceContextPropagator.getInstance(),
         new XCloudTraceContextPropagator(/*oneway=*/true));
@@ -44,9 +44,11 @@ public static void main(String... args) throws Exception {
             .setPropagators(ContextPropagators.create(propagators))
             .setTracerProvider(
                 SdkTracerProvider.builder()
-                    // Sample Rate set to always
+                    // Sample Rate is set to alwaysOn
+                    // It is recommended to sample based on a ratio for standard use ie.
+                    // .setSampler(Sampler.traceIdRatioBased(0.2)) // sample only 20% of trace ids
                     .setSampler(Sampler.alwaysOn())
-                    .addSpanProcessor(BatchSpanProcessor.builder(exporter).build())
+                    .addSpanProcessor(BatchSpanProcessor.builder(spanExporter).build())
                     .build())
             .build();
     StorageOptions options = StorageOptions.newBuilder().setOpenTelemetry(openTelemetry).build();