Skip to content

Commit

Permalink
fix: github workflow vulnerable to script injection (#2663)
Browse files Browse the repository at this point in the history
* inline repo's full_name as env var

Signed-off-by: Diogo Teles Sant'Anna <diogoteles@google.com>
Co-authored-by: Diego Marquez <diegomarquezp@google.com>
  • Loading branch information
diogoteles08 and diegomarquezp authored Sep 11, 2024
1 parent a7e4fd6 commit 9151ac2
Showing 1 changed file with 12 additions and 4 deletions.
16 changes: 12 additions & 4 deletions .github/workflows/hermetic_library_generation.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,14 @@ on:
paths:
- 'generation_config.yaml'


env:
HEAD_REF: ${{ github.head_ref }}
REPO_FULL_NAME: ${{ github.event.pull_request.head.repo.full_name }}
GITHUB_REPOSITORY: ${{ github.repository }}

jobs:
library_generation:
# skip pull requests coming from a forked repository
if: github.event.pull_request.head.repo.full_name == github.repository
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand All @@ -32,11 +36,15 @@ jobs:
- name: Generate changed libraries
shell: bash
run: |
set -x
set -ex
if [[ "${GITHUB_REPOSITORY}" != "${REPO_FULL_NAME}" ]]; then
echo "This PR comes from a fork. Generation will be skipped"
exit 0
fi
[ -z "$(git config user.email)" ] && git config --global user.email "cloud-java-bot@google.com"
[ -z "$(git config user.name)" ] && git config --global user.name "cloud-java-bot"
bash .github/scripts/hermetic_library_generation.sh \
--target_branch ${{ github.base_ref }} \
--current_branch ${{ github.head_ref }}
--current_branch $HEAD_REF
env:
GH_TOKEN: ${{ secrets.CLOUD_JAVA_BOT_TOKEN }}

0 comments on commit 9151ac2

Please sign in to comment.