Change bytesCopied initialization to -1

googleapis · Jun 2, 2023 · dde6d6c · dde6d6c
1 parent 7f50edc
commit dde6d6c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/...torage/src/main/java/com/google/cloud/storage/transfermanager/DirectDownloadCallable.java b/...torage/src/main/java/com/google/cloud/storage/transfermanager/DirectDownloadCallable.java
@@ -49,7 +49,7 @@ final class DirectDownloadCallable implements Callable<DownloadResult> {
   @Override
   public DownloadResult call() {
     Path path = TransferManagerUtils.createDestPath(parallelDownloadConfig, originalBlob);
-    long bytesCopied = 0L;
+    long bytesCopied = -1L;
     try (ReadChannel rc =
         storage.reader(
             BlobId.of(parallelDownloadConfig.getBucketName(), originalBlob.getName()), opts)) {
@@ -61,7 +61,7 @@ public DownloadResult call() {
               StandardOpenOption.TRUNCATE_EXISTING);
       bytesCopied = ByteStreams.copy(rc, wc);
     } catch (Exception e) {
-      if (bytesCopied == 0) {
+      if (bytesCopied == -1) {
         return DownloadResult.newBuilder(originalBlob, TransferStatus.FAILED_TO_START)
             .setException(e)
             .build();

diff --git a/...-cloud-storage/src/main/java/com/google/cloud/storage/transfermanager/UploadCallable.java b/...-cloud-storage/src/main/java/com/google/cloud/storage/transfermanager/UploadCallable.java
@@ -61,7 +61,7 @@ public UploadResult call() throws Exception {
   }
 
   private UploadResult uploadWithoutChunking() {
-    long bytesCopied = 0L;
+    long bytesCopied = -1L;
     try {
       Optional<BlobInfo> newBlob;
       try (FileChannel r = FileChannel.open(sourceFile, StandardOpenOption.READ);
@@ -74,7 +74,7 @@ private UploadResult uploadWithoutChunking() {
           .setUploadedBlob(newBlob.get())
           .build();
     } catch (Exception e) {
-      if (bytesCopied == 0) {
+      if (bytesCopied == -1) {
         return UploadResult.newBuilder(originalBlob, TransferStatus.FAILED_TO_START)
             .setException(e)
             .build();