-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add preconditions to some samples #1600
Merged
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1c93676
docs: Add preconditions to some samples
JesseLovelace 4eded73
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 3654653
remove star import
JesseLovelace 91c48f0
Merge branch 'jesseprecon' of github.com:googleapis/java-storage into…
JesseLovelace cc483c0
add null checks
JesseLovelace 438cc45
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] e7e4b71
Merge branch 'main' into jesseprecon
JesseLovelace File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,12 +44,21 @@ public static void changeObjectStorageClass( | |
StorageClass storageClass = StorageClass.COLDLINE; | ||
|
||
// You can't change an object's storage class directly, the only way is to rewrite the object | ||
// with the | ||
// desired storage class | ||
// with the desired storage class | ||
|
||
BlobInfo targetBlob = BlobInfo.newBuilder(blobId).setStorageClass(storageClass).build(); | ||
|
||
// Optional: set a generation-match precondition to avoid potential race | ||
// conditions and data corruptions. The request to upload returns a 412 error if | ||
// the object's generation number does not match your precondition. | ||
Storage.BlobSourceOption precondition = | ||
Storage.BlobSourceOption.generationMatch(storage.get(blobId).getGeneration()); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ditto |
||
|
||
Storage.CopyRequest request = | ||
Storage.CopyRequest.newBuilder() | ||
.setSource(blobId) | ||
.setTarget(BlobInfo.newBuilder(blobId).setStorageClass(storageClass).build()) | ||
.setSourceOptions(precondition) // delete this line to run without preconditions | ||
.setTarget(targetBlob) | ||
.build(); | ||
Blob updatedBlob = storage.copy(request).getResult(); | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,7 +32,15 @@ public static void deleteObject(String projectId, String bucketName, String obje | |
// String objectName = "your-object-name"; | ||
|
||
Storage storage = StorageOptions.newBuilder().setProjectId(projectId).build().getService(); | ||
storage.delete(bucketName, objectName); | ||
|
||
// Optional: set a generation-match precondition to avoid potential race | ||
// conditions and data corruptions. The request to upload returns a 412 error if | ||
// the object's generation number does not match your precondition. | ||
Storage.BlobSourceOption precondition = | ||
Storage.BlobSourceOption.generationMatch( | ||
storage.get(bucketName, objectName).getGeneration()); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ditto |
||
|
||
storage.delete(bucketName, objectName, precondition); | ||
|
||
System.out.println("Object " + objectName + " was deleted from " + bucketName); | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -48,11 +48,19 @@ public static void rotateObjectEncryptionKey( | |
|
||
Storage storage = StorageOptions.newBuilder().setProjectId(projectId).build().getService(); | ||
BlobId blobId = BlobId.of(bucketName, objectName); | ||
|
||
// Optional: set a generation-match precondition to avoid potential race | ||
// conditions and data corruptions. The request to upload returns a 412 error if | ||
// the object's generation number does not match your precondition. | ||
Storage.BlobSourceOption precondition = | ||
Storage.BlobSourceOption.generationMatch(storage.get(blobId).getGeneration()); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ditto |
||
|
||
// You can't change an object's encryption key directly, the only way is to overwrite the object | ||
Storage.CopyRequest request = | ||
Storage.CopyRequest.newBuilder() | ||
.setSource(blobId) | ||
.setSourceOptions(Storage.BlobSourceOption.decryptionKey(oldEncryptionKey)) | ||
.setSourceOptions( | ||
Storage.BlobSourceOption.decryptionKey(oldEncryptionKey), precondition) | ||
.setTarget(blobId, Storage.BlobTargetOption.encryptionKey(newEncryptionKey)) | ||
.build(); | ||
storage.copy(request); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could 404 and return null if there isn't an object for
blobId
. Possibly move it to it's own line to ease debugging?