Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update GrpcStorageOptions to set allowNonDefaultServiceAccount = true #1977

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

BenWhitehead
Copy link
Collaborator

No description provided.

@BenWhitehead BenWhitehead requested a review from a team as a code owner April 11, 2023 20:32
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/java-storage API. labels Apr 11, 2023
@@ -211,6 +211,7 @@ private Tuple<StorageSettings, Opts<UserProject>> resolveSettingsAndOpts() throw
InstantiatingGrpcChannelProvider.Builder channelProviderBuilder =
InstantiatingGrpcChannelProvider.newBuilder()
.setEndpoint(endpoint)
.setAllowNonDefaultServiceAccount(true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we think this should always be true? Should this be configurable?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My feeling, is this flag is there to support some old client which didn't have this capability. However, in the case of storage I think we always want to allow any kind of credential without requiring the customer to also know they need to flip this flag. I mean hell, I didn't even know this flag existed until dataproc tried to use the library and was surprised they weren't getting direct path and tracked it down to the credentials.

@BenWhitehead BenWhitehead merged commit f1b9493 into main Apr 12, 2023
@BenWhitehead BenWhitehead deleted the allowNonDefaultServiceAccount branch April 12, 2023 16:36
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 12, 2023
🤖 I have created a release *beep* *boop*
---


## [2.22.0](https://togithub.com/googleapis/java-storage/compare/v2.21.0...v2.22.0) (2023-04-12)


### Features

* Add matchGlob parameter to BlobListOption ([#1965](https://togithub.com/googleapis/java-storage/issues/1965)) ([93be97a](https://togithub.com/googleapis/java-storage/commit/93be97a9ae061241f510cbeb566f9f839063faa0))
* Handle generation numbers in BlobId#{to,from}GsUtilUri ([#1929](https://togithub.com/googleapis/java-storage/issues/1929)) ([0a033b3](https://togithub.com/googleapis/java-storage/commit/0a033b36a2be7e1d92c8b2f7323f2851005034cf))
* Implement GrpcStorageImpl#{get,list,create,delete}Notification ([#1958](https://togithub.com/googleapis/java-storage/issues/1958)) ([830052b](https://togithub.com/googleapis/java-storage/commit/830052b3f26337f50770436784f0ea9f3366dbca))
* Make it possible to disable the buffer of ReadChannels returned from Storage.reader ([#1974](https://togithub.com/googleapis/java-storage/issues/1974)) ([702ab2b](https://togithub.com/googleapis/java-storage/commit/702ab2bb1ceb9f428296591adc6e09023b4a8484))


### Bug Fixes

* Update GrpcStorageOptions to set allowNonDefaultServiceAccount = true ([#1977](https://togithub.com/googleapis/java-storage/issues/1977)) ([f1b9493](https://togithub.com/googleapis/java-storage/commit/f1b94930509c87ecbdbe6627fec6118305331780))


### Documentation

* Update spec for WriteObjectRequest.object_size to clarify that it applies to both one-shot and resumable writes ([#1976](https://togithub.com/googleapis/java-storage/issues/1976)) ([7354e19](https://togithub.com/googleapis/java-storage/commit/7354e198521384cd2b8583f073217a5a6cb74fe0))


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.7.0 ([#1978](https://togithub.com/googleapis/java-storage/issues/1978)) ([1f7e9c9](https://togithub.com/googleapis/java-storage/commit/1f7e9c9130a9516acfcdfda4b23e642fbe799146))
* Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.21 ([#1979](https://togithub.com/googleapis/java-storage/issues/1979)) ([d6accdf](https://togithub.com/googleapis/java-storage/commit/d6accdf9c81419728c39a61e348a61683dc117ad))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants