Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update modified field handling for blob and bucket with json transport to properly clear fields #2664

Merged
merged 1 commit into from
Aug 15, 2024

Commits on Aug 13, 2024

  1. fix: update modified field handling for blob and bucket with json tra…

    …nsport to properly clear fields
    
    Update StorageImpl#update(BlobInfo) and StorageImpl#update(BucketInfo) to only send modified fields in the case of an actual update. Currently, it simply sends the json version of the current info, this can mean that if a field is cleared the request to gcs doesn't actually include the field to clear.
    
    This same issue does not impact grpc transport, because grpc transport has an explicit `update_mask` that is populated.
    
    Fixes #2662
    BenWhitehead committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    bae9bb9 View commit details
    Browse the repository at this point in the history