Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add multi-modal support vector store #207

Merged
merged 12 commits into from
Sep 17, 2024
Merged

feat: Add multi-modal support vector store #207

merged 12 commits into from
Sep 17, 2024

Conversation

duwenxin99
Copy link
Contributor

@duwenxin99 duwenxin99 commented Aug 26, 2024

  1. Add new image search APIs similarity_search_image() and asimilarity_search_image().
  2. Add add_images() and aadd_images() endpoints to add images to vector store.
  3. Add tests.

@duwenxin99 duwenxin99 requested review from a team as code owners August 26, 2024 16:52
@product-auto-label product-auto-label bot added the api: alloydb Issues related to the googleapis/langchain-google-alloydb-pg-python API. label Aug 26, 2024
@duwenxin99 duwenxin99 marked this pull request as draft August 26, 2024 17:23
@duwenxin99 duwenxin99 self-assigned this Aug 27, 2024
@duwenxin99 duwenxin99 marked this pull request as ready for review August 27, 2024 21:26
Copy link
Collaborator

@averikitsch averikitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I manually tested this out and it's looking good. It might be helpful in your doc to describe the milestones of what is completed vs not completed ie GCS support.

Tagging in @kurtisvg as a python devex review on using both query/image_uris as inputs and how to handle differences in the embed_image interfaces while we sort out the interface with LangChain.

requirements.txt Outdated Show resolved Hide resolved
src/langchain_google_alloydb_pg/vectorstore.py Outdated Show resolved Hide resolved
src/langchain_google_alloydb_pg/vectorstore.py Outdated Show resolved Hide resolved
src/langchain_google_alloydb_pg/vectorstore.py Outdated Show resolved Hide resolved
src/langchain_google_alloydb_pg/vectorstore.py Outdated Show resolved Hide resolved
src/langchain_google_alloydb_pg/vectorstore.py Outdated Show resolved Hide resolved
src/langchain_google_alloydb_pg/vectorstore.py Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
tests/test_alloydb_vectorstore_search.py Outdated Show resolved Hide resolved
tests/test_alloydb_vectorstore_search.py Outdated Show resolved Hide resolved
tests/test_alloydb_vectorstore_search.py Outdated Show resolved Hide resolved
src/langchain_google_alloydb_pg/vectorstore.py Outdated Show resolved Hide resolved
src/langchain_google_alloydb_pg/vectorstore.py Outdated Show resolved Hide resolved
Copy link

conventional-commit-lint-gcf bot commented Sep 11, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@duwenxin99 duwenxin99 force-pushed the multi branch 4 times, most recently from e2d5cd9 to c6e68f0 Compare September 16, 2024 15:18
tests/test_async_vectorstore_search.py Show resolved Hide resolved
ids: Optional[List[str]] = None,
**kwargs: Any,
) -> List[str]:
"""Embed images and add to the table."""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the args to the doc string? We may also be able to call out the GCS support for the VertexAIEmbeddings model

@duwenxin99 duwenxin99 merged commit 8d259ba into main Sep 17, 2024
13 checks passed
@duwenxin99 duwenxin99 deleted the multi branch September 17, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: alloydb Issues related to the googleapis/langchain-google-alloydb-pg-python API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants