-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add multi-modal support vector store #207
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I manually tested this out and it's looking good. It might be helpful in your doc to describe the milestones of what is completed vs not completed ie GCS support.
Tagging in @kurtisvg as a python devex review on using both query/image_uris as inputs and how to handle differences in the embed_image interfaces while we sort out the interface with LangChain.
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
e2d5cd9
to
c6e68f0
Compare
ids: Optional[List[str]] = None, | ||
**kwargs: Any, | ||
) -> List[str]: | ||
"""Embed images and add to the table.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the args to the doc string? We may also be able to call out the GCS support for the VertexAIEmbeddings model
similarity_search_image()
andasimilarity_search_image()
.add_images()
andaadd_images()
endpoints to add images to vector store.