Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support create/list datasets on a different project #1230

Merged
merged 4 commits into from
Aug 1, 2023
Merged

feat: support create/list datasets on a different project #1230

merged 4 commits into from
Aug 1, 2023

Conversation

alvarowolfx
Copy link
Contributor

Override projectId used by the request method when projectId is informed when creating and referencing a dataset.

Fixes #1227 🦕

@alvarowolfx alvarowolfx requested review from a team as code owners July 27, 2023 18:18
@alvarowolfx alvarowolfx requested a review from chalmerlowe July 27, 2023 18:18
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/nodejs-bigquery API. labels Jul 27, 2023
@alvarowolfx alvarowolfx requested a review from shollyman July 27, 2023 18:18
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 27, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 27, 2023
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 27, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 27, 2023
shollyman
shollyman approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do we need to do similar in followup PRs for other resource types beyond datasets?

@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 31, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 31, 2023
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 1, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 1, 2023
@alvarowolfx alvarowolfx merged commit 86c63fb into googleapis:main Aug 1, 2023
@release-please release-please bot mentioned this pull request Aug 1, 2023
Merged
This was referenced Aug 8, 2023
Closed
Closed
Closed
@alvarowolfx alvarowolfx mentioned this pull request Aug 10, 2023
Closed
@atrbgithub
Copy link

Thanks for this @alvarowolfx 👍

@alvarowolfx alvarowolfx mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

@chalmerlowe chalmerlowe Awaiting requested review from chalmerlowe chalmerlowe is a code owner automatically assigned from googleapis/api-bigquery

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/nodejs-bigquery API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does createDataset support the supplying of a projectId?
3 participants
@alvarowolfx @atrbgithub @shollyman