-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable channel pooling #1065
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
Pull request size is medium.
api: bigtable
Issues related to the googleapis/nodejs-bigtable API.
labels
Apr 6, 2022
igorbernstein2
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Apr 6, 2022
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Apr 6, 2022
igorbernstein2
force-pushed
the
channel-pool
branch
from
April 6, 2022 17:54
97c5e1f
to
d445b2b
Compare
igorbernstein2
force-pushed
the
channel-pool
branch
from
April 6, 2022 20:48
4c71494
to
abaaf94
Compare
igorbernstein2
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Apr 6, 2022
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Apr 6, 2022
igorbernstein2
added
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
and removed
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
labels
Apr 6, 2022
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Apr 6, 2022
danieljbruce
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Apr 6, 2022
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Apr 6, 2022
danieljbruce
approved these changes
Apr 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nimf
approved these changes
Apr 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Apr 6, 2022
🤖 I have created a release *beep* *boop* --- ## [3.10.0](v3.9.4...v3.10.0) (2022-04-06) ### Features * Add ListHotTablets API method and protobufs ([#1057](#1057)) ([2b175ac](2b175ac)) * AuditConfig for IAM v1 ([#1061](#1061)) ([d1b5f1a](d1b5f1a)) * enable channel pooling ([#1065](#1065)) ([6c3c397](6c3c397)) ### Bug Fixes * disable retry-request, add exponential backoff in mutateRows and readRows ([#1060](#1060)) ([3718011](3718011)) * retry rst_stream errors ([#1059](#1059)) ([90de80f](90de80f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: bigtable
Issues related to the googleapis/nodejs-bigtable API.
size: m
Pull request size is medium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #1062
This enables the channel pool from grpc-gcp-node and configures it to have 2-4 channels and also enables encrypted gfe headers every 10 mins. The results of the headers can be viewed by enabling verbose grpc logs (
GRPC_TRACE=all GRPC_VERBOSITY=debug
), however they can only be decrypted by google engineers