build: check broken links in generated docs

.jsdoc.js

@@ -20,7 +20,7 @@ module.exports = {
   opts: {
     readme: './README.md',
     package: './package.json',
-    template: './node_modules/ink-docstrap/template',
+    template: './node_modules/jsdoc-baseline',
     recurse: true,
     verbose: true,
     destination: './docs/'

.kokoro/docs.sh

@@ -23,3 +23,11 @@ cd $(dirname $0)/..
 npm install
 
 npm run docs
+
+# Check broken links
+BIN=./node_modules/.bin
+
+npm install broken-link-checker
+npm install http-server
+$BIN/http-server -p 8080 docs/ &
+$BIN/blc http://localhost:8080 -r --exclude www.googleapis.com

package.json

@@ -51,7 +51,7 @@
     "eslint-config-prettier": "^3.0.0",
     "eslint-plugin-node": "^8.0.0",
     "eslint-plugin-prettier": "^3.0.0",
-    "ink-docstrap": "^1.3.2",
+    "jsdoc-baseline": "git+https://github.com/hegemonic/jsdoc-baseline.git",
     "intelli-espower-loader": "^1.0.1",
     "jsdoc": "^3.5.5",
     "mocha": "^5.0.0",

src/index.js

@@ -19,10 +19,13 @@
  * @namespace google.cloud
  */
 /**
- * @namespace google.cloud.container
+ * @namespace google.container
  */
 /**
- * @namespace google.cloud.container.v1
+ * @namespace google.container.v1
+ */
+/**
+ * @namespace google.protobuf
  */
 
 'use strict';

src/v1/doc/google/container/v1/doc_cluster_service.js

@@ -543,7 +543,7 @@ const IPAllocationPolicy = {
  *
  * @property {number} initialNodeCount
  *   The number of nodes to create in this cluster. You must ensure that your
- *   Compute Engine <a href="/compute/docs/resource-quotas">resource quota</a>
+ *   Compute Engine [resource quota](https://cloud.google.com/compute/docs/resource-quotas)
  *   is sufficient for this number of instances. You must also have available
  *   firewall and routes quota.
  *   For requests, this field should only be used in lieu of a
@@ -707,7 +707,7 @@ const IPAllocationPolicy = {
  *
  * @property {string} currentNodeVersion
  *   [Output only] Deprecated, use
- *   [NodePool.version](https://cloud.google.com/kubernetes-engine/docs/reference/rest/v1/projects.zones.clusters.nodePool)
+ *   [NodePool.version](https://cloud.google.com/kubernetes-engine/docs/reference/rest/v1/projects.zones.clusters.nodePools#resource-nodepool)
  *   instead. The current version of the node software components. If they are
  *   currently at multiple versions because they're in the process of being
  *   upgraded, this reflects the minimum version of all nodes.
@@ -1916,7 +1916,7 @@ const GetNodePoolRequest = {
  *
  * @property {number} initialNodeCount
  *   The initial node count for the pool. You must ensure that your
- *   Compute Engine <a href="/compute/docs/resource-quotas">resource quota</a>
+ *   Compute Engine [resource quota](https://cloud.google.com/compute/docs/resource-quotas)
  *   is sufficient for this number of instances. You must also have available
  *   firewall and routes quota.
  *

synth.py

@@ -22,6 +22,14 @@
 templates = common_templates.node_library()
 s.copy(templates)
 
+s.replace("src/v1/doc/google/container/v1/doc_cluster_service.js",
+        "<a href=\"\/compute\/docs\/resource-quotas\">resource quota<\/a>",
+        r"[resource quota](https://cloud.google.com/compute/docs/resource-quotas)")
+
+s.replace("src/v1/doc/google/container/v1/doc_cluster_service.js",
+        "https:\/\/cloud\.google\.com\/kubernetes-engine\/docs\/reference\/rest\/v1\/projects\.zones\.clusters\.nodePool",
+        "https://cloud.google.com/kubernetes-engine/docs/reference/rest/v1/projects.zones.clusters.nodePools#resource-nodepool")
+
 # Node.js specific cleanup
 subprocess.run(['npm', 'install'])
 subprocess.run(['npm', 'run', 'fix'])