-
Notifications
You must be signed in to change notification settings - Fork 14
docs(samples): add usage samples to show handling of LRO response Operation #519
Conversation
@sofisl - Please TAL and let me know if it's good! |
__Usage:__ | ||
|
||
|
||
`node samples/create_cluster.js` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This autogenerated usage is not correct. Im not sure how I can change this. In any case it doesn't break anything. The user will get a message indicating required args on first run
Warning: This pull request is touching the following templated files:
|
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
Thanks for the very detailed pull-request description, Shabir. 👏 I have yet to provide more rigorous feedback and test the two scripts. In the meantime, I realized that one of the tests is failing on Kokoro.
If we could somehow use Node.js 14.17 or higher, we could use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since all the create and delete files are so similar, all of my comments for create apply to delete as well.
Fixes #415
Description
Changes
google.container.v1.Operation
Testing