feat: Clients should support the universe domain option #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The user should be able to set the universe domain so that outgoing calls work with a different Google Cloud Universe. Right now, if the user specifies a universe domain then it will not get used and the request will just be sent to the default Datastore endpoint.
Analogous changes were made in googleapis/nodejs-bigtable#1563.
Changes:
src/index.ts: If a custom domain isn't provided and a universe domain is provided then instead of using the default url the client will send requests to a url for the universe domain.test/service-path.ts: Add tests for when user provides a universe domain or uses the universe domain environment variable.test/gapic-mocks/get-initialized-datastore-client.ts: A change to the test infrastructure that allows us to create a more realistic initialized Datastore client with a custom set of Datastore options.test/request.ts: The linter is now complaining about this file so a cast is needed.