chore(deps): update dependency eslint to v5

[renovate]

This Pull Request updates dependency eslint from ^4.9.0 to ^5.0.0

Note: This PR was created on a configured schedule ("after 10pm,before 5am") and will not receive updates outside those times.

Release Notes

v5.1.0

Compare Source

• 7328f99 Build: package.json update for eslint-config-eslint release (ESLint Jenkins)
• b161f6b Build: Include prerelease install info in release blog post (#​10463) (Kevin Partington)
• b2df738 Fix: prefer-object-spread duplicated comma (fixes #​10512, fixes #​10532) (#​10524) (Toru Nagashima)
• d8c3a25 Fix: wrap-regex doesn't work in some expression(fixes #​10573) (#​10576) (薛定谔的猫)
• 114f42e Docs: Clarify option defaults in max-lines-per-function docs (#​10569) (Chris Harwood)
• 63f36f7 Fix: sort-keys in an object that contains spread (fixes #​10261) (#​10495) (katerberg)
• 601a5c4 Fix: Prefer-const rule crashing on array destructuring (fixes #​10520) (#​10527) (Michael Mason)
• 143890a Update: Adjust grammar of error/warnings fixable (#​10546) (Matt Mischuk)
• 8ee39c5 Chore: small refactor config-validator (#​10565) (薛定谔的猫)
• 100f1be Docs: add note about release issues to readme (#​10572) (Teddy Katz)
• 02efeac Fix: do not fail on nested unknown operators (#​10561) (Rubén Norte)
• 92b19ca Chore: use eslintrc overrides(dogfooding) (#​10566) (薛定谔的猫)
• 076a6b6 Docs: add actionable fix to no-irregular-whitespace (#​10558) (Matteo Collina)
• de663ec Docs: Only successfully linted files are cached (fixes #​9802) (#​10557) (Kevin Partington)
• f0e22fc Upgrade: globals@​11.7.0 (#​10497) (薛定谔的猫)
• 8a2ff2c Docs: adding a section about disable rules for some files (#​10536) (Wellington Soares)
• f22a3f8 Docs: fix a word in no-implied-eval (#​10539) (Dan Homola)
• 20d8bbd Docs: add missing paragraph about "custom parsers" (#​10547) (Pig Fang)
• b7addf6 Update: deprecate no-catch-shadow (fixes #​10466) (#​10526) (Toru Nagashima)
• e862dc3 Fix: Remove autofixer for no-debugger (fixes #​10242) (#​10509) (Teddy Katz)

---

v5.0.1

Compare Source

• 196c102 Fix: valid-jsdoc should allow optional returns for async (fixes #​10386) (#​10480) (Mark Banner)
• 4c823bd Docs: Fix max-lines-per-function correct code's max value (#​10513) (Rhys Bower)

---

v5.0.0

Compare Source
Release blogpost

Migration guide

• 0feedfd New: Added max-lines-per-function rule (fixes #​9842) (#​10188) (peteward44)
• daefbdb Upgrade: eslint-scope and espree to 4.0.0 (refs #​10458) (#​10500) (Brandon Mills)
• 077358b Docs: no-process-exit: recommend process.exitCode (#​10478) (Andres Kalle)
• f93d6ff Fix: do not fail on unknown operators from custom parsers (fixes #​10475) (#​10476) (Rubén Norte)
• 05343fd Fix: add parens for yield statement (fixes #​10432) (#​10468) (Pig Fang)
• d477c5e Fix: check destructuring for "no-shadow-restricted-names" (fixes #​10467) (#​10470) (Pig Fang)
• 7a7580b Update: Add considerPropertyDescriptor option to func-name-matching (#​9078) (Dieter Luypaert)
• e0a0418 Fix: crash on optional catch binding (#​10429) (Toru Nagashima)
• de4dba9 Docs: styling team members (#​10460) (薛定谔的猫)
• 5e453a3 Docs: display team members in tables. (#​10433) (薛定谔的猫)
• b1895eb Docs: Restore intentional spelling mistake (#​10459) (Wilfred Hughes)

---

---

This PR has been generated by Renovate Bot.

[googlebot]

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

[alexander-fenster]

@rarkins Looks like something is wrong with commit signature here - even though we have "gitAuthor": null set in settings and all regular commits satisfy Google CLA bot, this one triggers the warnings because it thinks that the PR was updated by someone other than its original author.

Looks like the bot amended the commit here, is it using different gitAuthor for amended commits?

[Also, thanks so much for Renovate - we are currently in progress of moving all our repositories to it and looks like it will solve a lot of our problems with lock file and dependency maintenance!]

[alexander-fenster]

[please ignore the lint failure here, it's unrelated]

[rarkins]

@alexander-fenster I changed gitAuthor to be an admin-only setting this week, meaning it's no longer controllable via repository config. My main concern was people using it to generate confusing commits (e.g. impersonating another user, which is entirely possible with git anyway but I didn't want to be the one to make it easy).

I already had a server-side rule to disable gitAuthor for known Google CLA bot accounts but wasn't aware of this one. I've added it now so any subsequent commits should come from the same renovate[bot] account that's creating the PRs, therefore satisfying the CLA bot.

I can see that you have "rebaseStalePrs": true, set in your config, so that should happen the next time anyone commits to master. You could perhaps trigger that deliberately by removing the gitAuthor config line now (https://github.com/dialogflow/dialogflow-nodejs-client-v2/blob/87e4f897c480a285d18dadf913aab2533819db0e/renovate.json#L17).. don't forget the preceding comma too :)

[rarkins]

Also, please let me know if there are any other Google orgs that disabling gitAuthor should be set for and I'll configure it in the bot.

[jkwlui]

@alexander-fenster what's the status on this renovate PR? I'd love to merge that in before I cut a release.

[alexander-fenster]

@kinwa91 Someone (probably @crwilcox or you) should take a look what's going wrong with lint task here and in #135. Both don't block release, it just looks like something has changed in eslint so that the lint task started failing. Can I ask you to take a look and fix the task if needed?

Thanks!

[googlebot]

CLAs look good, thanks!

[renovate]

PR has been edited

As this PR has been edited, Renovate will stop updating it in order to not cause any conflicts or other problems. If you wish to abandon your edits and have Renovate recreate this PR then you should rename this PR and then close it.

[jkwlui]

@alexander-fenster fyi, lint failed here because starting from 5.x, it fails if we pass an empty directory to eslint for it to lint.

As for #135 (eslint-plugin-node-7.x), it requires eslint >=4.19.1, so the requirement will be satisfied once this is merged in first.

[jkwlui]

lint has a different error this time (addressed in #136)

[rarkins]

You might also want to consider adding the preset "group:linters" to Renovate's config. It groups together all lint packages (eslint, tslint, etc) into a single PR, which is usually preferable than upgrading them individually and having to think about peerDependencies.