Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

fix: update expected images for redact samples test #78

Merged
merged 1 commit into from
Jul 3, 2018

Conversation

jkwlui
Copy link
Member

@jkwlui jkwlui commented Jul 3, 2018

Fixes: #77

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 3, 2018
@ghost ghost assigned jkwlui Jul 3, 2018
@jkwlui jkwlui requested a review from ace-n July 3, 2018 22:34
@codecov
Copy link

codecov bot commented Jul 3, 2018

Codecov Report

Merging #78 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #78   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines           4      4           
=====================================
  Hits            4      4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 259dcec...9cf6410. Read the comment docs.

@ace-n
Copy link
Contributor

ace-n commented Jul 3, 2018

This is probably the quickest fix.

It has been an issue in the past, however - so a more permanent fix would be to scan the resulting image for an appropriate sub-image (at a fixed position). We might be able to use sharp for that.

@jkwlui
Copy link
Member Author

jkwlui commented Jul 3, 2018

Thanks @ace-n! I opened an issue regarding the potential fix.

@jkwlui jkwlui merged commit 4f1e56e into master Jul 3, 2018
@jkwlui jkwlui deleted the fix-redact-samples-test branch July 3, 2018 22:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants