Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Query Profile #2014

Merged
merged 43 commits into from
Mar 25, 2024
Merged

feat: Query Profile #2014

merged 43 commits into from
Mar 25, 2024

Conversation

ehsannas
Copy link
Contributor

No description provided.

ehsannas and others added 29 commits October 18, 2023 14:29
@ehsannas
Add QueryMode protos.
5685b37
@ehsannas
WIP: Query profiling APIs.
16fcd28
@ehsannas
Use generic type.
e806883
@ehsannas
WIP WIP.
0d1febb
@ehsannas
WIP WIP WIP.
265f1ff
@ehsannas
Update integration tests.
af54637
@ehsannas
clean up.
8cb527d
@ehsannas
lint.
69da273
@ehsannas
Fix: Do not re-use _stream().
cc35f56
@ehsannas
Address more feedback.
9f987dd
@ehsannas
introduce QueryPlan class to make it possible to add node-level info …
40ded3a 
…in future.
@ehsannas
Merge remote-tracking branch 'origin/main' into query_profiling_impl_2
ce6df90
@ehsannas
fix lint errors.
9819c5e
@ehsannas
Revert host setting.
ccaad87
@ehsannas
undo manual proto updates.
834ddc9
@ehsannas
Merge remote-tracking branch 'origin/main' into query_profiling_impl_…
bb2fbe8 
…merge
@ehsannas
Merge remote-tracking branch 'origin/main' into query_profiling_impl_…
74b7f15 
…merge
@ehsannas
Update the public APIs to v2.
7c3cf77
@ehsannas
Reuse existing _stream methods.
2c4944c
@ehsannas
Introduce ExplainMetrics and PlanSummary.
71935d1
@ehsannas
Update tests.
4621073
@ehsannas
Manually import query profile protos.
3bdb616
@ehsannas
WIP: Update impl and tests with new protos.
81d0bf6
@ehsannas
WIP (2): Update impl and tests with new protos.
2e9d274
@ehsannas
WIP (3): Update impl and tests with new protos.
a31a514
@ehsannas
WIP (4): Update impl and tests with new protos.
0c7c9da
@ehsannas
Add test for explainStream.
985a972
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
b735f47 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@ehsannas
Merge remote-tracking branch 'origin/main' into query_profiling_impl_…
7bf7078 
…v2_4
@ehsannas ehsannas requested a review from a team as a code owner March 13, 2024 23:32
@ehsannas ehsannas force-pushed the ehsann/query_profiling_impl_v2_4 branch from c567d72 to 68d4909 Compare March 15, 2024 21:57
@ehsannas ehsannas force-pushed the ehsann/query_profiling_impl_v2_4 branch from 68d4909 to 95a2111 Compare March 15, 2024 21:58
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Mar 15, 2024
@ehsannas ehsannas requested a review from MarkDuckworth March 18, 2024 22:19
@ehsannas ehsannas assigned MarkDuckworth and unassigned ehsannas Mar 18, 2024
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Mar 19, 2024
MarkDuckworth
MarkDuckworth reviewed Mar 20, 2024
View reviewed changes
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback for API reference documentation. This is not a release blocker, but ideally should be addressed before release.

You can preview the api reference docs generated for cloud.google.com using these two steps:

  1. yarn cloud-rad to generate the _devsite folder
  2. Install, configure, and serve the _devsite folder using instructions at https://www.npmjs.com/package/@google-cloud/cloud-rad

This is the best process I found to get my documentation right.

Also note that this PR will have missing content in the API reference at https://googleapis.dev/nodejs/firestore/latest. But that's using a different system, and the current target is CGC docs.

dev/src/query-profile.ts Outdated Show resolved Hide resolved
dev/src/query-profile.ts Show resolved Hide resolved
dev/src/query-profile.ts Outdated Show resolved Hide resolved
dev/src/query-profile.ts Show resolved Hide resolved
dev/src/query-profile.ts Outdated Show resolved Hide resolved
dev/src/query-profile.ts Show resolved Hide resolved
dev/src/query-profile.ts Show resolved Hide resolved
dev/src/query-profile.ts Outdated Show resolved Hide resolved
MarkDuckworth
MarkDuckworth approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the remainder. LGTM, but the api reference comments should be considered before release.

@ehsannas ehsannas added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 25, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 25, 2024
MarkDuckworth
MarkDuckworth approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ehsannas ehsannas merged commit 9a45ec8 into main Mar 25, 2024
18 checks passed
@ehsannas ehsannas deleted the ehsann/query_profiling_impl_v2_4 branch March 25, 2024 22:02
@release-please release-please bot mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkDuckworth MarkDuckworth MarkDuckworth approved these changes

Assignees

@MarkDuckworth MarkDuckworth

Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehsannas @MarkDuckworth @yoshi-kokoro