Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Query Profile #2014

Merged
merged 43 commits into from
Mar 25, 2024
Merged
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
5685b37
Add QueryMode protos.
ehsannas Oct 18, 2023
16fcd28
WIP: Query profiling APIs.
ehsannas Jul 25, 2023
e806883
Use generic type.
ehsannas Jul 31, 2023
0d1febb
WIP WIP.
ehsannas Oct 20, 2023
265f1ff
WIP WIP WIP.
ehsannas Oct 25, 2023
af54637
Update integration tests.
ehsannas Oct 26, 2023
8cb527d
clean up.
ehsannas Oct 26, 2023
69da273
lint.
ehsannas Oct 26, 2023
cc35f56
Fix: Do not re-use _stream().
ehsannas Nov 21, 2023
9f987dd
Address more feedback.
ehsannas Nov 21, 2023
40ded3a
introduce QueryPlan class to make it possible to add node-level info …
ehsannas Jan 4, 2024
ce6df90
Merge remote-tracking branch 'origin/main' into query_profiling_impl_2
ehsannas Jan 4, 2024
9819c5e
fix lint errors.
ehsannas Jan 4, 2024
ccaad87
Revert host setting.
ehsannas Jan 4, 2024
834ddc9
undo manual proto updates.
ehsannas Jan 10, 2024
bb2fbe8
Merge remote-tracking branch 'origin/main' into query_profiling_impl_…
ehsannas Jan 10, 2024
74b7f15
Merge remote-tracking branch 'origin/main' into query_profiling_impl_…
ehsannas Jan 11, 2024
7c3cf77
Update the public APIs to v2.
ehsannas Feb 9, 2024
2c4944c
Reuse existing _stream methods.
ehsannas Feb 10, 2024
71935d1
Introduce ExplainMetrics and PlanSummary.
ehsannas Feb 23, 2024
4621073
Update tests.
ehsannas Feb 23, 2024
3bdb616
Manually import query profile protos.
ehsannas Mar 7, 2024
81d0bf6
WIP: Update impl and tests with new protos.
ehsannas Mar 8, 2024
2e9d274
WIP (2): Update impl and tests with new protos.
ehsannas Mar 8, 2024
a31a514
WIP (3): Update impl and tests with new protos.
ehsannas Mar 8, 2024
0c7c9da
WIP (4): Update impl and tests with new protos.
ehsannas Mar 8, 2024
985a972
Add test for explainStream.
ehsannas Mar 8, 2024
b735f47
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Mar 9, 2024
7bf7078
Merge remote-tracking branch 'origin/main' into query_profiling_impl_…
ehsannas Mar 13, 2024
371c66d
Remove bytesReturned from the API.
ehsannas Mar 13, 2024
95a2111
Merge remote-tracking branch 'origin/main' into query_profiling_impl_…
ehsannas Mar 15, 2024
0fd0f9e
minor improvements.
ehsannas Mar 15, 2024
4f984fe
minor improvements.
ehsannas Mar 15, 2024
d00b7cf
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Mar 15, 2024
c52d77d
improve documentation.
ehsannas Mar 15, 2024
74c2f3f
Fix unit test failure.
ehsannas Mar 15, 2024
460d3f1
minor improvements.
ehsannas Mar 18, 2024
fd2d50e
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Mar 18, 2024
1e13262
explain options should be optional.
ehsannas Mar 19, 2024
974ca2a
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Mar 19, 2024
4a3f8c2
Address feedback.
ehsannas Mar 22, 2024
391edb8
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Mar 22, 2024
7501e4f
Merge branch 'main' into ehsann/query_profiling_impl_v2_4
MarkDuckworth Mar 25, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] committed Mar 22, 2024

Verified

This commit was signed with the committer’s verified signature.
Aaronontheweb Aaron Stannard
commit 391edb870ca1d9132b7b795619d088ffedda5239
2 changes: 1 addition & 1 deletion dev/src/index.ts
Original file line number Diff line number Diff line change
@@ -118,7 +118,7 @@ export type {
PlanSummary,
ExecutionStats,
ExplainMetrics,
ExplainResults
ExplainResults,
} from './query-profile';

const libVersion = require('../../package.json').version;
12 changes: 6 additions & 6 deletions types/firestore.d.ts
Original file line number Diff line number Diff line change
@@ -39,8 +39,8 @@ declare namespace FirebaseFirestore {
| (T extends Primitive
? T
: T extends {}
? {[K in keyof T]?: PartialWithFieldValue<T[K]> | FieldValue}
: never);
? {[K in keyof T]?: PartialWithFieldValue<T[K]> | FieldValue}
: never);

/**
* Allows FieldValues to be passed in as a property value while maintaining
@@ -51,8 +51,8 @@ declare namespace FirebaseFirestore {
| (T extends Primitive
? T
: T extends {}
? {[K in keyof T]: WithFieldValue<T[K]> | FieldValue}
: never);
? {[K in keyof T]: WithFieldValue<T[K]> | FieldValue}
: never);

/**
* Update data (for use with [update]{@link DocumentReference#update})
@@ -71,8 +71,8 @@ declare namespace FirebaseFirestore {
export type UpdateData<T> = T extends Primitive
? T
: T extends {}
? {[K in keyof T]?: UpdateData<T[K]> | FieldValue} & NestedUpdateFields<T>
: Partial<T>;
? {[K in keyof T]?: UpdateData<T[K]> | FieldValue} & NestedUpdateFields<T>
: Partial<T>;

/** Primitive types. */
export type Primitive = string | number | boolean | undefined | null;