Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: drop through2 #1014

Merged
merged 3 commits into from
Apr 17, 2020
Merged

Conversation

schmidt-sebastian
Copy link
Contributor

Drops dependency on through2 (though dev dependency remains). Also drops readable-stream as Node10 supports async iterator out of the box.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 13, 2020
@schmidt-sebastian schmidt-sebastian changed the base branch from mrschmidt/updatedeps to node10 April 17, 2020 17:29
@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #1014 into node10 will decrease coverage by 0.00%.
The diff coverage is 99.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           node10    #1014      +/-   ##
==========================================
- Coverage   98.54%   98.54%   -0.01%     
==========================================
  Files          25       25              
  Lines       16614    16613       -1     
  Branches     1258     1255       -3     
==========================================
- Hits        16372    16371       -1     
  Misses        239      239              
  Partials        3        3              
Impacted Files Coverage Δ
dev/src/v1/firestore_client.ts 97.64% <98.96%> (ø)
dev/src/v1beta1/firestore_client.ts 97.38% <99.01%> (ø)
dev/src/v1/firestore_admin_client.ts 97.71% <99.07%> (ø)
dev/src/index.ts 98.28% <100.00%> (+<0.01%) ⬆️
dev/src/reference.ts 99.84% <100.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d6888d...94b07cc. Read the comment docs.

@schmidt-sebastian
Copy link
Contributor Author

IT'S HAPPENING NOW!

@schmidt-sebastian schmidt-sebastian merged commit 36a1683 into node10 Apr 17, 2020
schmidt-sebastian added a commit that referenced this pull request Jun 24, 2020
* fix!: mark v1beta1 client as deprecated (#937)

* feat!: use QueryDocumentSnapshot in FirestoreDataConverter (#965)

* deps: update to gts 2.x (#1013)

* chore!: update settings for Node 10 (#1019)

* deps: drop through2 (#1014)

* feat: support BigInt (#1016)

* fix: make update.sh work on Linux (#1043)

* fix: only use BigInt in BigInt system test (#1044)

* fix: make pbjs compile admin proto again (#1045)

* Add BulkWriter (#1055)

* docs: Add documentation for FirestoreDataConverter (#1059)

* chore: enforce return types (#1065)

* fix: add generic to Firestore.getAll() (#1066)

* chore: remove internal WriteOp (#1067)

* chore: add linter checks for it|describe.only (#1068)

* fix: handle terminate in BulkWriter (#1070)

* chore: run template copying last in synthtool (#1071)

* feat: Firestore Bundles implementation (#1078)

* feat: add support for set() with SetOptions when using FirestoreDataConverter (#1087)

* feat: Add totalDocuments and totalBytes to bundle metadata. (#1085)

* feat: Add totalDocuments and totalBytes to bundle metadata.

* fix: Better comment

* fix: Better testing.

* fix: Improve metadata testing.

* fix: incomplete expect in rate-limiter test (#1092)

* Remove BatchWrite proto, fix conformance tests

* chore: use public API types internally (#1100)

* feat: add Partition and BatchWrite protos (#1110)

* fix: remove GCF transaction fallback (#1112)

* fix: add BulkWriter integration tests, java backport changes, delete fix (#1117)

* chore: merge master (#1218)

* chore: add eslint check for console.log statements (#1229)

* fix: another attempt at fixing the flaky BulkWriter test (#1228)

* Fix comment

* Renames

* Test fix

* Fix unit tests

Co-authored-by: Brian Chen <chenbrian@google.com>
Co-authored-by: wu-hui <53845758+wu-hui@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants