feat: Add support to convert a Query to a BundledQuery. #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## wuandy/Bundles #1034 +/- ##
==================================================
- Coverage 97.46% 97.45% -0.01%
==================================================
Files 25 25
Lines 16015 16044 +29
Branches 1218 1217 -1
==================================================
+ Hits 15609 15636 +27
- Misses 403 405 +2
Partials 3 3
Continue to review full report at Codecov.
|
schmidt-sebastian
approved these changes
Apr 22, 2020
dev/src/reference.ts
Outdated
| structuredQuery, | ||
| }; | ||
|
|
||
| reqOpts.transaction = transactionId; |
There was a problem hiding this comment.
Nit: Merge this into the assignment above.
dev/src/reference.ts
Outdated
|
|
||
| reqOpts.transaction = transactionId; | ||
|
|
||
| return reqOpts; |
There was a problem hiding this comment.
Possible inline?
dev/src/reference.ts
Outdated
|
|
||
| /** | ||
| * Internal method for serializing a query to its RunQuery proto | ||
| * representation with an optional transaction id. |
There was a problem hiding this comment.
This documentation seems not applicable.
| }, | ||
| ], | ||
| }; | ||
| if (this._queryOptions.allDescendants) { |
There was a problem hiding this comment.
Nit: Empty line above
| o.toProto() | ||
| ); | ||
| } | ||
| structuredQuery.startAt = this.toCursor(this._queryOptions.startAt); |
There was a problem hiding this comment.
Nit: Empty line above
wu-hui
added a commit
that referenced
this pull request
Apr 24, 2020
* Update from googleapis.git * Add bundle.proto. * Move bundle.proto to a different folder. * Add support to convert a Query to a BundledQuery. * Move the proto file again * Move the proto file again * Update package name. * Update to use new package name.
wu-hui
added a commit
that referenced
this pull request
Apr 24, 2020
* Update from googleapis.git * Add bundle.proto. * Move bundle.proto to a different folder. * Add support to convert a Query to a BundledQuery. * Move the proto file again * Move the proto file again * Update package name. * Update to use new package name.
wu-hui
added a commit
that referenced
this pull request
May 13, 2020
* Update from googleapis.git * Add bundle.proto. * Move bundle.proto to a different folder. * Add support to convert a Query to a BundledQuery. * Move the proto file again * Move the proto file again * Update package name. * Update to use new package name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note the tricky thing here is: we introduced limitToLast, which means we need to decide if the
structuredQuerysaved in the bundle should be translated or not.This implementation saves it without translation, which means the client SDK will use the
structureQueryandlimitTypesaved here to construct a new clientQuery, and leaves the translation to the existing logic on the client side.