Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Nonblocking rollback #2039

Merged
merged 1 commit into from
May 6, 2024
Merged

fix: Nonblocking rollback #2039

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions dev/src/transaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,16 +516,20 @@ export class Transaction implements firestore.Transaction {
this._transactionIdPromise = undefined;
this._prevTransactionId = transactionId;

try {
await this._firestore.request('rollback', request, this._requestTag);
} catch (err) {
logger(
'Firestore.runTransaction',
this._requestTag,
'Best effort to rollback failed with error:',
err
);
}
// We don't need to wait for rollback to completed before continuing.
// If there are any locks held, then rollback will eventually release them.
// Rollback can be done concurrently thereby reducing latency caused by
// otherwise blocking.
this._firestore
.request('rollback', request, this._requestTag)
.catch(err => {
logger(
'Firestore.runTransaction',
this._requestTag,
'Best effort to rollback failed with error:',
err
);
});
}

/**
Expand Down
Loading