Slightly better error messages #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
schmidt-sebastian
force-pushed
the
mrschmidt-bettererror
branch
3 times, most recently
from
751554f to
27b78a0
Compare
schmidt-sebastian
force-pushed
the
mrschmidt-bettererror
branch
from
27b78a0 to
9806572
Compare
mikelehen
approved these changes
Nov 12, 2018
dev/src/index.ts
Outdated
| ArrayElement: (name, value) => | ||
| validateFieldValue(name, value, /* depth */ 0, /*inArray=*/true), | ||
| ArrayElement: (name, value) => validateFieldValue( | ||
| name, value, /* path */ undefined, /*level=*/0, |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dev/src/index.ts
Outdated
| * @param options Validation options | ||
| * @param depth The current depth of the traversal. | ||
| * @param level The current depth of the traversal. This is used to decided |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -477,20 +481,29 @@ export class FieldPath extends Path<FieldPath> { | |||
| */ | |||
| static validateFieldPath(fieldPath: string|FieldPath) { | |||
| if (!(fieldPath instanceof FieldPath)) { | |||
| if (!is.string(fieldPath)) { | |||
| if (fieldPath === undefined) { | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #436 and https://b.corp.google.com/issues/78932093
This PR: