-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal: Exclude conformance tests from code coverage #729
Conversation
@bcoe: If I am not mistaken, conventional commits using the commit message from the merge commit, which is the PR title. Is that correct? It's a bit of a pain to update a PR that from an edit on GitHub, so I am inclined to leave the original commit message as is. |
Codecov Report
@@ Coverage Diff @@
## master #729 +/- ##
=======================================
Coverage 96.06% 96.06%
=======================================
Files 20 20
Lines 2234 2234
Branches 475 475
=======================================
Hits 2146 2146
Misses 22 22
Partials 66 66 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure this is one of those files that gets overwritten by synthtool every time. We'd need to include this in the default template in synthtool.
This is the file we need to change: After that's in, we need to do a hammer PR to make the change (happy to do that). Also - for the conventional commits bit I think the |
See googleapis/nodejs-firestore#729 for first failed attempt.
See googleapis/nodejs-firestore#729 for first failed attempt.
No description provided.