Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Exclude conformance tests from code coverage #729

Closed
wants to merge 1 commit into from

Conversation

schmidt-sebastian
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 8, 2019
@schmidt-sebastian
Copy link
Contributor Author

@bcoe: If I am not mistaken, conventional commits using the commit message from the merge commit, which is the PR title. Is that correct? It's a bit of a pain to update a PR that from an edit on GitHub, so I am inclined to leave the original commit message as is.

@codecov
Copy link

codecov bot commented Aug 8, 2019

Codecov Report

Merging #729 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #729   +/-   ##
=======================================
  Coverage   96.06%   96.06%           
=======================================
  Files          20       20           
  Lines        2234     2234           
  Branches      475      475           
=======================================
  Hits         2146     2146           
  Misses         22       22           
  Partials       66       66

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5693347...34592b2. Read the comment docs.

Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this is one of those files that gets overwritten by synthtool every time. We'd need to include this in the default template in synthtool.

@JustinBeckwith
Copy link
Contributor

This is the file we need to change:
https://github.com/googleapis/synthtool/blob/master/synthtool/gcp/templates/node_library/.nycrc

After that's in, we need to do a hammer PR to make the change (happy to do that).

Also - for the conventional commits bit I think the chore: prefix or test: prefix would be the right answer :)

schmidt-sebastian added a commit to schmidt-sebastian/synthtool that referenced this pull request Aug 9, 2019
bcoe pushed a commit to googleapis/synthtool that referenced this pull request Sep 6, 2019
@schmidt-sebastian schmidt-sebastian deleted the schmidt-sebastian-patch-1 branch January 3, 2020 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants