Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: update library to use Node 12 #466

Merged
merged 7 commits into from
May 10, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/.OwlBot.lock.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@
# limitations under the License.
docker:
image: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest
digest: sha256:b9e4584a1fe3c749e3c37c92497b13dce653b2e694f0261f0610eb0e15941357
digest: sha256:079b0f3bd8427671745ec03a5179575b4c86a4e776fb6041427e553719c65c2b
# created: 2022-05-05T21:08:42.530332893Z
2 changes: 1 addition & 1 deletion .github/sync-repo-settings.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ branchProtectionRules:
- "ci/kokoro: System test"
- docs
- lint
- test (10)
- test (12)
- test (14)
- test (16)
- cla/google
- windows
- OwlBot Post Processor
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [10, 12, 14]
node: [12, 14, 16]
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
Expand Down
34 changes: 0 additions & 34 deletions .kokoro/continuous/node10/common.cfg

This file was deleted.

4 changes: 0 additions & 4 deletions .kokoro/continuous/node10/docs.cfg

This file was deleted.

9 changes: 0 additions & 9 deletions .kokoro/continuous/node10/test.cfg

This file was deleted.

12 changes: 0 additions & 12 deletions .kokoro/continuous/node8/browser-test.cfg

This file was deleted.

24 changes: 0 additions & 24 deletions .kokoro/continuous/node8/common.cfg

This file was deleted.

Empty file.
34 changes: 0 additions & 34 deletions .kokoro/presubmit/node10/common.cfg

This file was deleted.

4 changes: 0 additions & 4 deletions .kokoro/presubmit/node10/docs.cfg

This file was deleted.

4 changes: 0 additions & 4 deletions .kokoro/presubmit/node10/lint.cfg

This file was deleted.

Empty file.
24 changes: 0 additions & 24 deletions .kokoro/presubmit/node8/common.cfg

This file was deleted.

Empty file removed .kokoro/presubmit/node8/test.cfg
Empty file.
2 changes: 0 additions & 2 deletions owlbot.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,3 @@
common_templates = gcp.CommonTemplates()
templates = common_templates.node_library()
s.copy(templates)
node.install()
node.fix()
10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"dependencies": {
"extend": "^3.0.2",
"gaxios": "^4.0.0",
"google-auth-library": "^7.14.0",
"google-auth-library": "^8.0.2",
"qs": "^6.7.0",
"url-template": "^2.0.8",
"uuid": "^8.0.0"
Expand All @@ -58,7 +58,7 @@
"c8": "^7.0.0",
"codecov": "^3.5.0",
"execa": "^5.0.0",
"gts": "^2.0.0",
"gts": "^3.1.0",
"http2spy": "^2.0.0",
"is-docker": "^2.0.0",
"karma": "^6.0.0",
Expand All @@ -70,7 +70,7 @@
"karma-sourcemap-loader": "^0.3.7",
"karma-webpack": "^5.0.0",
"linkinator": "^2.0.0",
"mocha": "^8.3.2",
"mocha": "^9.2.2",
"mv": "^2.1.1",
"ncp": "^2.0.0",
"nock": "^13.0.0",
Expand All @@ -80,11 +80,11 @@
"sinon": "^14.0.0",
"tmp": "^0.2.0",
"ts-loader": "^8.0.0",
"typescript": "^3.8.3",
"typescript": "^4.6.4",
"webpack": "^5.30.0",
"webpack-cli": "^4.0.0"
},
"engines": {
"node": ">=10.10.0"
"node": ">=12.0.0"
}
}
4 changes: 2 additions & 2 deletions samples/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"license": "MIT",
"author": "Google LLC",
"engines": {
"node": ">=8"
"node": ">=12.0.0"
},
"files": [
"*.js",
Expand All @@ -20,4 +20,4 @@
"devDependencies": {
"mocha": "^8.0.0"
}
}
}
2 changes: 1 addition & 1 deletion src/apiIndex.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export function getAPI<T>(
return Object.freeze(ep) as T;
} catch (e) {
throw new Error(
`Unable to load endpoint ${api}("${version}"): ${e.message}`
`Unable to load endpoint ${api}("${version}"): ${(e as Error).message}`
);
}
}
4 changes: 2 additions & 2 deletions src/discovery.ts
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ export class Discovery {
'Unable to load endpoint %s("%s"): %s',
set.api.name,
version,
e.message
(e as Error).message
)
);
}
Expand All @@ -134,7 +134,7 @@ export class Discovery {
* @returns A promise that resolves with a function that creates the endpoint
*/
async discoverAPI(
apiDiscoveryUrl: string | {url: string}
apiDiscoveryUrl: string | {url?: string}
): Promise<EndpointCreator> {
if (typeof apiDiscoveryUrl === 'string') {
const parts = resolve.parse(apiDiscoveryUrl);
Expand Down